Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Additionally, I would like to apply the attached patch. Are there
> objections?
So far I think you only applied one half of that?
regards, tom lane
---(end of broadcast)---
TIP 1
I wrote:
> It looks to me like RS_isRegis() needs to be tightened up a bit anyway:
> it will accept "^foo" which is valid regex but not valid regis, leading
> to an error being thrown which is not what we want.
I experimented with this and verified that the error could be reached
with a hacked-up
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> Teodor Sigaev wrote:
>> Hmm. If regis detects an error in expression then it will be an error for
>> regex library too. At least, it was supposed to be.
> And those that are not, probably are not what the user intends anyway,
> with the pattern languag
Teodor Sigaev wrote:
>> aren't user-facing errors at all, and should be demoted to elog's,
>> correct?
>>
>> elog(ERROR, "invalid regis pattern: \"%s\"", str);
>
> Hmm. If regis detects an error in expression then it will be an error for
> regex library too. At least, it was suppos
aren't user-facing errors at all, and should be demoted to elog's,
correct?
elog(ERROR, "invalid regis pattern: \"%s\"", str);
Hmm. If regis detects an error in expression then it will be an error for regex
library too. At least, it was supposed to be.
--
Teodor Sigaev
Teodor Sigaev <[EMAIL PROTECTED]> writes:
> There is a fallback to regex if expression isn't supported by regis (see
> call
> of RS_isRegis() in spell.c).
Oh. So in that case, the messages Alvaro is worried about
ereport(ERROR,
(errcode(ERRCODE_INVALID_
Maybe the right phrase to use is "ispell regular expression". In any
case we need to document what the limitations are compared to "regular"
regular expressions (ahem). Do you know offhand what the rules are?
There is a fallback to regex if expression isn't supported by regis (see call
of RS
Teodor Sigaev <[EMAIL PROTECTED]> writes:
>> web I don't find any other reference to "regises" (regisen? reges?), so
>> I think we should avoid using the term. How about just changing the
>> messages to just say "regular expression" instead?
> It's just a combination of "regular expression for i
For example, in regis.c there are several strings talking about "regis
pattern". I had never heard of regis patterns. Turns out they are a
fast regex subset, used AFAICT only by the ispell code. Searching the
web I don't find any other reference to "regises" (regisen? reges?), so
I think we sho
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> For example, in regis.c there are several strings talking about "regis
> pattern". I had never heard of regis patterns. Turns out they are a
> fast regex subset, used AFAICT only by the ispell code. Searching the
> web I don't find any other reference
Hi,
While translating the backend's message catalog I found several things
that should probably be improved.
For example, in regis.c there are several strings talking about "regis
pattern". I had never heard of regis patterns. Turns out they are a
fast regex subset, used AFAICT only by the ispe
11 matches
Mail list logo
