Re: [HACKERS] matview patch readability/correctness gripe

2013-03-14 Thread Kevin Grittner
Kevin Grittner wrote: > Tom Lane wrote: > >> diff --git a/src/backend/rewrite/rewriteDefine.c >> b/src/backend/rewrite/rewriteDefine.c >> index >> a1a9808e5d94959218b415ed34c46579c478c177..896326615753f2344b466eb180080174ddeda31d >> 100644 >> *** a/src/backend/rewrite/rewriteDefine.c >> --- b/s

Re: [HACKERS] matview patch readability/correctness gripe

2013-03-13 Thread Kevin Grittner
Tom Lane wrote: > diff --git a/src/backend/rewrite/rewriteDefine.c > b/src/backend/rewrite/rewriteDefine.c > index > a1a9808e5d94959218b415ed34c46579c478c177..896326615753f2344b466eb180080174ddeda31d > 100644 > *** a/src/backend/rewrite/rewriteDefine.c > --- b/src/backend/rewrite/rewriteDefine.c

[HACKERS] matview patch readability/correctness gripe

2013-03-11 Thread Tom Lane
While looking for the cause of Erikjan Rijkers' recent report, my attention was drawn to this hunk of the matview patch: diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c index a1a9808e5d94959218b415ed34c46579c478c177..896326615753f2344b466eb180080174ddeda31d