Re: [HACKERS] libpq URI and regression testing

2012-07-06 Thread Alvaro Herrera
Excerpts from Alex's message of jue abr 19 17:06:05 -0300 2012: > Peter Eisentraut writes: > > > On tor, 2012-04-19 at 00:13 +0300, Alex wrote: > >> +#!/usr/bin/env perl > > > > Don't do that. Call the script using $(PERL) from the makefile. > > Thank you for the suggestion. Attached v2 does

Re: [HACKERS] libpq URI and regression testing

2012-04-19 Thread Alex
Peter Eisentraut writes: > On tor, 2012-04-19 at 00:13 +0300, Alex wrote: >> +#!/usr/bin/env perl > > Don't do that. Call the script using $(PERL) from the makefile. Thank you for the suggestion. Attached v2 does just this (while keeping a more commonly found shebang line in the perl script fo

Re: [HACKERS] libpq URI and regression testing

2012-04-19 Thread Peter Eisentraut
On tor, 2012-04-19 at 00:13 +0300, Alex wrote: > +#!/usr/bin/env perl Don't do that. Call the script using $(PERL) from the makefile. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] libpq URI and regression testing

2012-04-18 Thread Alex
Andrew Dunstan writes: >>> That's one reason for that, but there are probably others in the way of >>> making this fully portable and automatable. > > This test setup also appears to labor under the illusion that we live > in a Unix-only world. And for no good reason that I can tell. The > shell

Re: [HACKERS] libpq URI and regression testing

2012-04-18 Thread Alex
Peter Eisentraut writes: > On tis, 2012-04-17 at 10:47 -0300, Alvaro Herrera wrote: >> What's the preferred way to make it automatically tested as much as >> possible? I know the buildfarm does not run "installcheck-world", so if >> we want it there, it'd need a bit more code on the client side

Re: [HACKERS] libpq URI and regression testing

2012-04-17 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of mar abr 17 16:03:50 -0300 2012: > >> That's one reason for that, but there are probably others in the way of > >> making this fully portable and automatable. > > This test setup also appears to labor under the illusion that we live in > a Unix-only worl

Re: [HACKERS] libpq URI and regression testing

2012-04-17 Thread Andrew Dunstan
On 04/17/2012 02:47 PM, Alvaro Herrera wrote: Excerpts from Peter Eisentraut's message of mar abr 17 15:41:04 -0300 2012: On tis, 2012-04-17 at 10:47 -0300, Alvaro Herrera wrote: What's the preferred way to make it automatically tested as much as possible? I know the buildfarm does not run "

Re: [HACKERS] libpq URI and regression testing

2012-04-17 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mar abr 17 15:41:04 -0300 2012: > On tis, 2012-04-17 at 10:47 -0300, Alvaro Herrera wrote: > > What's the preferred way to make it automatically tested as much as > > possible? I know the buildfarm does not run "installcheck-world", so if > > we want it

Re: [HACKERS] libpq URI and regression testing

2012-04-17 Thread Peter Eisentraut
On tis, 2012-04-17 at 10:47 -0300, Alvaro Herrera wrote: > What's the preferred way to make it automatically tested as much as > possible? I know the buildfarm does not run "installcheck-world", so if > we want it there, it'd need a bit more code on the client side. I think > it would be wise to

[HACKERS] libpq URI and regression testing

2012-04-17 Thread Alvaro Herrera
Hi, When I committed Alex Shulgin's patch to add URI support to libpq, I included the test harness as well. However, due to it being in a separate subdirectory that did not previously had tests, it's not being run by buildfarm. It's not considered in "make installcheck-world" either. What's