Re: [HACKERS] json_build* volatility error

2014-07-15 Thread Tom Lane
Andrew Dunstan writes: > Are we trying to store these up or just applying them as they go? No, just do it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/p

Re: [HACKERS] json_build* volatility error

2014-07-15 Thread Andrew Dunstan
On 07/15/2014 11:14 AM, Tom Lane wrote: I think we need to fix this for 9.4. It will mean a catalog bump :-( Agreed. Are we trying to store these up or just applying them as they go? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y

Re: [HACKERS] json_build* volatility error

2014-07-15 Thread Tom Lane
Andrew Dunstan writes: > I have just noticed that I inadvertently marked the json_build* > functions as immutable. That seems to be a plain error, as, for example, > timestamptz output will not be immutable. Ah, yes, our convention is that anything depending on datatype I/O functions is to be m

[HACKERS] json_build* volatility error

2014-07-15 Thread Andrew Dunstan
I have just noticed that I inadvertently marked the json_build* functions as immutable. That seems to be a plain error, as, for example, timestamptz output will not be immutable. I think we need to fix this for 9.4. It will mean a catalog bump :-( cheers andrew -- Sent via pgsql-hackers mai