Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-07 Thread Michael Paquier
On Wed, Jun 8, 2016 at 8:21 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Michael Paquier writes: >> > On Tue, Jun 7, 2016 at 12:31 PM, Michael Paquier >> > wrote: >> >> On Tue, Jun 7, 2016 at 12:28 AM, Alvaro Herrera >> >> wrote: >> >>> Hmm, so we could solve the complaint by adding an ANALYZ

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-07 Thread Alvaro Herrera
Tom Lane wrote: > Michael Paquier writes: > > On Tue, Jun 7, 2016 at 12:31 PM, Michael Paquier > > wrote: > >> On Tue, Jun 7, 2016 at 12:28 AM, Alvaro Herrera > >> wrote: > >>> Hmm, so we could solve the complaint by adding an ANALYZE. I'm open to > >>> that; other opinions? > > >> We could ju

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-07 Thread Tom Lane
Michael Paquier writes: > On Tue, Jun 7, 2016 at 12:31 PM, Michael Paquier > wrote: >> On Tue, Jun 7, 2016 at 12:28 AM, Alvaro Herrera >> wrote: >>> Hmm, so we could solve the complaint by adding an ANALYZE. I'm open to >>> that; other opinions? >> We could just enforce work_mem to 64kB and th

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Michael Paquier
On Tue, Jun 7, 2016 at 12:31 PM, Michael Paquier wrote: > On Tue, Jun 7, 2016 at 12:28 AM, Alvaro Herrera > wrote: >> Tom Lane wrote: >>> Alvaro Herrera writes: >> >>> > I can't imagine that the server is avoiding hash aggregation on a 1MB >>> > work_mem limit for data that's a few dozen of byte

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Michael Paquier
On Tue, Jun 7, 2016 at 12:28 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Alvaro Herrera writes: > >> > I can't imagine that the server is avoiding hash aggregation on a 1MB >> > work_mem limit for data that's a few dozen of bytes. Is it really doing >> > that? >> >> Yup: > > Aha. Thanks for

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Tom Lane
I wrote: > Alvaro Herrera writes: >> Tom Lane wrote: >>> Presumably what is happening is that the planner is switching from hash >>> to sort aggregation. >> I can't imagine that the server is avoiding hash aggregation on a 1MB >> work_mem limit for data that's a few dozen of bytes. Is it really

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > I can't imagine that the server is avoiding hash aggregation on a 1MB > > work_mem limit for data that's a few dozen of bytes. Is it really doing > > that? > > Yup: Aha. Thanks for testing. > Now that you mention it, this does seem a bit odd, alth

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Presumably what is happening is that the planner is switching from hash >> to sort aggregation. > I can't imagine that the server is avoiding hash aggregation on a 1MB > work_mem limit for data that's a few dozen of bytes. Is it really doing > that? Y

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Michael Paquier wrote: > >> I know that we guarantee that make installcheck may not work on many > >> target servers as a lot of tests are very GUC-sensitive, but this > >> looks a bit oversensitive to me, especially knowing that it is the > >> only dif

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Tom Lane
Alvaro Herrera writes: > Michael Paquier wrote: >> I know that we guarantee that make installcheck may not work on many >> target servers as a lot of tests are very GUC-sensitive, but this >> looks a bit oversensitive to me, especially knowing that it is the >> only diff generated by the whole tes

Re: [HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Alvaro Herrera
Michael Paquier wrote: > I know that we guarantee that make installcheck may not work on many > target servers as a lot of tests are very GUC-sensitive, but this > looks a bit oversensitive to me, especially knowing that it is the > only diff generated by the whole test suite. > Don't you think th

[HACKERS] installcheck failing on psql_crosstab

2016-06-06 Thread Michael Paquier
Hi all, With a low value of work_mem, like 1MB, I am noticing that the new psql_crosstab is generating a couple of diffs with installcheck (tested only on OSX 10.11): *** *** 127,134 \crosstabview v h i v | h0 | h1 | h2 | h4 | #null# +++++-