Re: [HACKERS] incorrect libpq comment

2016-10-20 Thread Robert Haas
On Wed, Oct 19, 2016 at 1:35 PM, Bruce Momjian wrote: > On Wed, Oct 19, 2016 at 01:16:28PM -0400, Robert Haas wrote: >> Bruce's commit 5d305d86bd917723f09ab4f15c075d90586a210a back in April >> of 2014 includes this change: >> >> /* See PQconnectPoll() for how we use 'int' and not 'pgsocket'.

Re: [HACKERS] incorrect libpq comment

2016-10-19 Thread Bruce Momjian
On Wed, Oct 19, 2016 at 01:16:28PM -0400, Robert Haas wrote: > Bruce's commit 5d305d86bd917723f09ab4f15c075d90586a210a back in April > of 2014 includes this change: > > /* See PQconnectPoll() for how we use 'int' and not 'pgsocket'. */ > -int sock; /* Unix FD for socket,

[HACKERS] incorrect libpq comment

2016-10-19 Thread Robert Haas
Bruce's commit 5d305d86bd917723f09ab4f15c075d90586a210a back in April of 2014 includes this change: /* See PQconnectPoll() for how we use 'int' and not 'pgsocket'. */ -int sock; /* Unix FD for socket, -1 if not connected */ +pgsocketsock; /* FD for sock