Re: [HACKERS] include host names in hba error messages

2011-07-29 Thread Robert Haas
On Fri, Jul 29, 2011 at 2:44 PM, Peter Eisentraut wrote: > On tis, 2011-07-19 at 14:17 -0400, Robert Haas wrote: >> I think it would be less confusing to write the IP address as the main >> piece of information, and put the hostname in parentheses only if we >> accepted it as valid (i.e. we did bo

Re: [HACKERS] include host names in hba error messages

2011-07-29 Thread Peter Eisentraut
On tis, 2011-07-19 at 14:17 -0400, Robert Haas wrote: > I think it would be less confusing to write the IP address as the main > piece of information, and put the hostname in parentheses only if we > accepted it as valid (i.e. we did both lookups, and everything > matched). > > ERROR: no pg_hba.co

Re: [HACKERS] include host names in hba error messages

2011-07-19 Thread Robert Haas
On Tue, Jul 19, 2011 at 2:18 AM, Peter Eisentraut wrote: > Since we are accepting host names in pg_hba.conf now, I figured it could > be useful to also show the host names in error message, e.g., > >    no pg_hba.conf entry for host "localhost" (127.0.0.1), user "x", database > "y" > > Attached i

[HACKERS] include host names in hba error messages

2011-07-18 Thread Peter Eisentraut
Since we are accepting host names in pg_hba.conf now, I figured it could be useful to also show the host names in error message, e.g., no pg_hba.conf entry for host "localhost" (127.0.0.1), user "x", database "y" Attached is an example patch. The question might be what criterion to use for