Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

I wrote: > kar...@sao.ru (Sergey V. Karpov) writes: >> Andres Freund writes: >>> Looks nice. The only small gripe I have is that the patch adds trailing >>> whitespaces at a lot of places... >> My fault. Please check the patch version attached - I've tried to fix >> all those. > I did some mino

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

kar...@sao.ru (Sergey V. Karpov) writes: > Andres Freund writes: >> Looks nice. The only small gripe I have is that the patch adds trailing >> whitespaces at a lot of places... > My fault. Please check the patch version attached - I've tried to fix > all those. I did some minor cleanup on this

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

Andres Freund writes: Hi Andres, > Looks nice. The only small gripe I have is that the patch adds trailing > whitespaces at a lot of places... > > Except maybe that I do see no need for changes anymore... My fault. Please check the patch version attached - I've tried to fix all those. Thanks,

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

On Wed, Jul 29, 2009 at 6:59 PM, Andres Freund wrote: > Looks nice. The only small gripe I have is that the patch adds trailing > whitespaces at a lot of places... > > Except maybe that I do see no need for changes anymore... I have fixed this for Sergey in the attached version using "git apply --

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

Hi Sergey, Sorry that the second round took almost as long as the first one... On Monday 27 July 2009 12:01:46 Sergey V. Karpov wrote: > > - Imho mode=MAP should error out if keeporig is false > > - I personally find the the names for the different modes a bit > > nondescriptive. One possibility

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

Andres Freund writes: Hi Andres, Thank you for review of my patch. > Some points: > - Patch looks generally sound > - lacks a bit of a motivational statement, even though one can imagine uses The patch has initially been motivated by the request in pgsql-general (http://archives.postgresql.org

Re: [HACKERS] improvements for dict_xsyn extended synonym dictionary - RRR

Hi Sergey, On Tuesday 14 July 2009 21:35:28 Sergey V. Karpov wrote: > attached is a simple patch that extends the functionality of dict_xsyn > extended synonym dictionary (from contrib) by adding the following > configuration option: > > - "mode" option controls the current dictionary mode of oper