Re: [HACKERS] hstore isexists

2006-10-11 Thread Bruce Momjian
Jim C. Nasby wrote: > On Wed, Oct 11, 2006 at 05:00:50PM -0400, Tom Lane wrote: > > "Jim C. Nasby" <[EMAIL PROTECTED]> writes: > > > Sorry, I don't know the history of hstore... but if it's brand new, why > > > are we worried about backwards compatibility? > > > > Because it's been available for a

Re: [HACKERS] hstore isexists

2006-10-11 Thread Jim C. Nasby
On Wed, Oct 11, 2006 at 05:00:50PM -0400, Tom Lane wrote: > "Jim C. Nasby" <[EMAIL PROTECTED]> writes: > > Sorry, I don't know the history of hstore... but if it's brand new, why > > are we worried about backwards compatibility? > > Because it's been available for awhile outside of contrib (namely

Re: [HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Jim C. Nasby wrote: Sorry, I don't know the history of hstore... but if it's brand new, why are we worried about backwards compatibility? It has existed for a while, but has not previously been in contrib. cheers andrew ---(end of broadcast)---

Re: [HACKERS] hstore isexists

2006-10-11 Thread Tom Lane
"Jim C. Nasby" <[EMAIL PROTECTED]> writes: > Sorry, I don't know the history of hstore... but if it's brand new, why > are we worried about backwards compatibility? Because it's been available for awhile outside of contrib (namely, on Oleg and Teodor's own site). So there are people using it.

Re: [HACKERS] hstore isexists

2006-10-11 Thread Jim C. Nasby
On Wed, Oct 11, 2006 at 04:17:19PM -0400, Andrew Dunstan wrote: > Jim C. Nasby wrote: > >On Wed, Oct 11, 2006 at 10:04:10AM -0400, Andrew Dunstan wrote: > > > >>Teodor Sigaev wrote: > >> > >>>It's possible to create function 'exists' and mention only it in docs. > >>> > >>Good point. Wi

Re: [HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Jim C. Nasby wrote: On Wed, Oct 11, 2006 at 10:04:10AM -0400, Andrew Dunstan wrote: Teodor Sigaev wrote: It's possible to create function 'exists' and mention only it in docs. Good point. Will you do that, or do you want me to? ISTM it would be better to mention the depre

Re: [HACKERS] hstore isexists

2006-10-11 Thread Jim C. Nasby
On Wed, Oct 11, 2006 at 10:04:10AM -0400, Andrew Dunstan wrote: > Teodor Sigaev wrote: > >It's possible to create function 'exists' and mention only it in docs. > > Good point. Will you do that, or do you want me to? ISTM it would be better to mention the deprecated version and explicitly state

Re: [HACKERS] hstore isexists

2006-10-11 Thread [EMAIL PROTECTED]
>> 'exists' isn't a good name for function :(. >> > > Yeah, that isn't going to work. Perhaps "ifexists"? Or just leave well > enough alone. > > > Darn. Can't have been thinking clearly this morning. How about "exist" (no s)? Maybe 'found', 'present', or 'contains'?  (no, I h

Re: [HACKERS] hstore isexists

2006-10-11 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > How about "exist" (no s)? Seems a bit ugly, but better than isexists or ifexists ... regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Tom Lane wrote: Teodor Sigaev <[EMAIL PROTECTED]> writes: 'exists' isn't a good name for function :(. Yeah, that isn't going to work. Perhaps "ifexists"? Or just leave well enough alone. Darn. Can't have been thinking clearly this morning. How about "exist" (no s)? cheers a

Re: [HACKERS] hstore isexists

2006-10-11 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > 'exists' isn't a good name for function :(. Yeah, that isn't going to work. Perhaps "ifexists"? Or just leave well enough alone. regards, tom lane ---(end of broadcast)--- TIP 3:

Re: [HACKERS] hstore isexists

2006-10-11 Thread Teodor Sigaev
'exists' isn't a good name for function :(. From gram.y: col_name_keyword: ... function_name: IDENT { $$ = $1; } | unreserved_keyword{ $$ = pstrdup($1); } | func_name_keyword { $$

Re: [HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Teodor Sigaev wrote: Andrew Dunstan wrote: Teodor Sigaev wrote: It's possible to create function 'exists' and mention only it in docs. Good point. Will you do that, or do you want me to? May I ask you? I'm afraid that there is more incorrectness. Well, "isdefined" isn't incorrect, but

Re: [HACKERS] hstore isexists

2006-10-11 Thread Teodor Sigaev
Andrew Dunstan wrote: Teodor Sigaev wrote: It's possible to create function 'exists' and mention only it in docs. Good point. Will you do that, or do you want me to? May I ask you? I'm afraid that there is more incorrectness. -- Teodor Sigaev E-mail: [EM

Re: [HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Teodor Sigaev wrote: It's possible to create function 'exists' and mention only it in docs. Good point. Will you do that, or do you want me to? Bruce Momjian wrote: Andrew Dunstan wrote: Before we spring hstore on an unsuspecting world as a contrib module, in the interests of good English

Re: [HACKERS] hstore isexists

2006-10-11 Thread Teodor Sigaev
It's possible to create function 'exists' and mention only it in docs. Bruce Momjian wrote: Andrew Dunstan wrote: Before we spring hstore on an unsuspecting world as a contrib module, in the interests of good English, is it too late to change "isexists" to simply "exists"? Sure, we can do it

Re: [HACKERS] hstore isexists

2006-10-11 Thread Bruce Momjian
Andrew Dunstan wrote: > > Before we spring hstore on an unsuspecting world as a contrib module, in > the interests of good English, is it too late to change "isexists" to > simply "exists"? Sure, we can do it, as long as we aren't worried about adding incompatibilities for existing hstore users

[HACKERS] hstore isexists

2006-10-11 Thread Andrew Dunstan
Before we spring hstore on an unsuspecting world as a contrib module, in the interests of good English, is it too late to change "isexists" to simply "exists"? cheers andrew ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ?