Re: [HACKERS] hstore compiler warnings

2013-03-21 Thread Kevin Grittner
Andrew Dunstan wrote: > [assign to local variable and then `(void) varname;` to avoid "unused" > warning] > This is the only thing that I have found to work with very recent gcc. Seems > ugly. Anyone got a better idea? That seems to be what we've used elsewhere. http://www.postgresql.org/m

Re: [HACKERS] hstore compiler warnings

2013-03-21 Thread Andrew Dunstan
On 03/21/2013 11:18 AM, Andrew Dunstan wrote: On 03/21/2013 10:46 AM, Kevin Grittner wrote: Is anyone looking at these?: hstore_io.c: In function ‘hstore_to_json_loose’: hstore_io.c:1312:5: warning: ignoring return value of ‘strtol’, declared with attribute warn_unused_result [-Wunused-resul

Re: [HACKERS] hstore compiler warnings

2013-03-21 Thread Andrew Dunstan
On 03/21/2013 10:46 AM, Kevin Grittner wrote: Is anyone looking at these?: hstore_io.c: In function ‘hstore_to_json_loose’: hstore_io.c:1312:5: warning: ignoring return value of ‘strtol’, declared with attribute warn_unused_result [-Wunused-result] hstore_io.c:1324:6: warning: ignoring return

[HACKERS] hstore compiler warnings

2013-03-21 Thread Kevin Grittner
Is anyone looking at these?: hstore_io.c: In function ‘hstore_to_json_loose’: hstore_io.c:1312:5: warning: ignoring return value of ‘strtol’, declared with attribute warn_unused_result [-Wunused-result] hstore_io.c:1324:6: warning: ignoring return value of ‘strtod’, declared with attribute warn_