Re: [HACKERS] generic explain options v3 - RR Review

2009-07-19 Thread Robert Haas
On Sun, Jul 19, 2009 at 9:47 AM, Andres Freund wrote: > On Sunday 19 July 2009 14:39:33 Martijn van Oosterhout wrote: >> On Sun, Jul 19, 2009 at 03:15:38AM +0200, Andres Freund wrote: >> > Hi Robert, Hi All, >> > >> > Patch applies with some offset changes, code changes look sensible, I >> > person

Re: [HACKERS] generic explain options v3 - RR Review

2009-07-19 Thread Andres Freund
On Sunday 19 July 2009 14:39:33 Martijn van Oosterhout wrote: > On Sun, Jul 19, 2009 at 03:15:38AM +0200, Andres Freund wrote: > > Hi Robert, Hi All, > > > > Patch applies with some offset changes, code changes look sensible, I > > personally like the new syntax and the features it may allow in fut

Re: [HACKERS] generic explain options v3 - RR Review

2009-07-19 Thread Martijn van Oosterhout
On Sun, Jul 19, 2009 at 03:15:38AM +0200, Andres Freund wrote: > Hi Robert, Hi All, > > Patch applies with some offset changes, code changes look sensible, I > personally like the new syntax and the features it may allow in future. One, > possibly big, gripe remains though: > The formerly valid

Re: [HACKERS] generic explain options v3 - RR Review

2009-07-18 Thread Andres Freund
Hi Robert, Hi All, Patch applies with some offset changes, code changes look sensible, I personally like the new syntax and the features it may allow in future. One, possibly big, gripe remains though: The formerly valid statement which cannot be written without the parentheses and stay semanti