Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-29 Thread Robert Haas
On Mon, Apr 27, 2015 at 10:59 AM, Andrew Dunstan wrote: > Yeah. I've pushed this with tiny fixes to avoid Leaning Toothpick Syndrome > (man perlop for definition). I had to Google that. Then I had to think about it. Then I laughed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-27 Thread Andrew Dunstan
On 04/27/2015 08:46 AM, Michael Paquier wrote: On Mon, Apr 27, 2015 at 9:25 PM, Peter Eisentraut wrote: On 4/27/15 2:09 AM, Michael Paquier wrote: 2) I noticed that VC builds do not like *at all* file paths with forward slashes, perhaps it could be possible to use a Condition like hasForwardS

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-27 Thread Michael Paquier
On Mon, Apr 27, 2015 at 9:25 PM, Peter Eisentraut wrote: > On 4/27/15 2:09 AM, Michael Paquier wrote: >> 2) I noticed that VC builds do not like *at all* file paths with >> forward slashes, perhaps it could be possible to use a Condition like >> hasForwardSlashes but it seems safer to simply enfor

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-27 Thread Peter Eisentraut
On 4/27/15 2:09 AM, Michael Paquier wrote: > 2) I noticed that VC builds do not like *at all* file paths with > forward slashes, perhaps it could be possible to use a Condition like > hasForwardSlashes but it seems safer to simply enforce the file paths > to use backslashes in the vcproj files. Tha

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Michael Paquier
On Mon, Apr 27, 2015 at 9:20 AM, Michael Paquier wrote: > On Mon, Apr 27, 2015 at 8:53 AM, Andrew Dunstan wrote: >> >> On 04/26/2015 04:08 PM, Noah Misch wrote: >>> >>> On Sun, Apr 26, 2015 at 10:23:58AM -0400, Andrew Dunstan wrote: Setting up a VS2008 environment is hard these days, as

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Michael Paquier
On Mon, Apr 27, 2015 at 8:53 AM, Andrew Dunstan wrote: > > On 04/26/2015 04:08 PM, Noah Misch wrote: >> >> On Sun, Apr 26, 2015 at 10:23:58AM -0400, Andrew Dunstan wrote: >>> >>> Setting up a VS2008 environment is hard these days, as MS seems to have >>> removed the download :-( >> >> Visual C++ 2

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Andrew Dunstan
On 04/26/2015 04:08 PM, Noah Misch wrote: On Sun, Apr 26, 2015 at 10:23:58AM -0400, Andrew Dunstan wrote: Setting up a VS2008 environment is hard these days, as MS seems to have removed the download :-( Visual C++ 2008 Express Edition: http://go.microsoft.com/?linkid=7729279 Oh, cool. Thank

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Noah Misch
On Sun, Apr 26, 2015 at 10:23:58AM -0400, Andrew Dunstan wrote: > Setting up a VS2008 environment is hard these days, as MS seems to have > removed the download :-( Visual C++ 2008 Express Edition: http://go.microsoft.com/?linkid=7729279 -- Sent via pgsql-hackers mailing list (pgsql-hackers@pos

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Andrew Dunstan
On 04/26/2015 03:13 AM, Michael Paquier wrote: Oops, attached is a patch that should make currawong happier.. OK, pushed. Argh. This is not enough: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-26%2006%3A00%3A01 The build is done in Debug mode, but it is failing

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-26 Thread Michael Paquier
On Sun, Apr 26, 2015 at 10:29 AM, Andrew Dunstan wrote: > > On 04/25/2015 08:01 PM, Michael Paquier wrote: >> >> On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan >> wrote: >>> >>> On 04/25/2015 10:53 AM, Michael Paquier wrote: On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote:

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-25 Thread Andrew Dunstan
On 04/25/2015 08:01 PM, Michael Paquier wrote: On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan wrote: On 04/25/2015 10:53 AM, Michael Paquier wrote: On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote: On 4/24/15 12:22 AM, Michael Paquier wrote: Now that the stuff related to the move fr

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-25 Thread Michael Paquier
On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan wrote: > > On 04/25/2015 10:53 AM, Michael Paquier wrote: >> >> On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote: >>> >>> On 4/24/15 12:22 AM, Michael Paquier wrote: Now that the stuff related to the move from contrib/ to src/bin/, >

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-25 Thread Andrew Dunstan
On 04/25/2015 10:53 AM, Michael Paquier wrote: On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote: On 4/24/15 12:22 AM, Michael Paquier wrote: Now that the stuff related to the move from contrib/ to src/bin/, modulescheck and tmp_install has been committed, shouldn't we give a new shot at

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-25 Thread Michael Paquier
On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote: > On 4/24/15 12:22 AM, Michael Paquier wrote: >> Now that the stuff related to the move from contrib/ to src/bin/, >> modulescheck and tmp_install has been committed, shouldn't we give a >> new shot at this patch? Attached is a rebased versio

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-25 Thread Peter Eisentraut
On 4/24/15 12:22 AM, Michael Paquier wrote: > On Fri, Mar 13, 2015 at 6:04 PM, Michael Paquier > wrote: >> On Fri, Mar 13, 2015 at 6:20 AM, Alvaro Herrera wrote: >>> Peter Eisentraut wrote: This is contrib/chkpass not finding the crypt symbol, which is presumably in some library. But I

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-04-23 Thread Michael Paquier
On Fri, Mar 13, 2015 at 6:04 PM, Michael Paquier wrote: > On Fri, Mar 13, 2015 at 6:20 AM, Alvaro Herrera wrote: >> Peter Eisentraut wrote: >>> This is contrib/chkpass not finding the crypt symbol, which is >>> presumably in some library. But I can't see how it would normally find >>> it, without

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-03-13 Thread Michael Paquier
On Fri, Mar 13, 2015 at 6:20 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> This is contrib/chkpass not finding the crypt symbol, which is >> presumably in some library. But I can't see how it would normally find >> it, without my patch. > > It seems crypt is provided by libpgport. So chk

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-03-12 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 3/4/15 11:00 PM, Andrew Dunstan wrote: > > > > On 03/04/2015 10:37 PM, Peter Eisentraut wrote: > >> I can't tell from just looking at the code how chkpass would normally > >> find crypt. The msvc tools neither parse SHLIB_LINK nor have hardcoded > >> knowledge. Any

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-03-12 Thread Peter Eisentraut
On 3/4/15 11:00 PM, Andrew Dunstan wrote: > > On 03/04/2015 10:37 PM, Peter Eisentraut wrote: >> On 2/15/15 6:55 AM, Michael Paquier wrote: >>> I tested quickly the second patch with MS 2010 and I am getting a >>> build failure: chkpass cannot complete because of crypt missing. On >>> master build

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-03-04 Thread Andrew Dunstan
On 03/04/2015 10:37 PM, Peter Eisentraut wrote: On 2/15/15 6:55 AM, Michael Paquier wrote: I tested quickly the second patch with MS 2010 and I am getting a build failure: chkpass cannot complete because of crypt missing. On master build passes. More details here: "C:\Users\mpaquier\git\postgre

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-03-04 Thread Peter Eisentraut
On 2/15/15 6:55 AM, Michael Paquier wrote: > I tested quickly the second patch with MS 2010 and I am getting a > build failure: chkpass cannot complete because of crypt missing. On > master build passes. More details here: > "C:\Users\mpaquier\git\postgres\pgsql.sln" (default target) (1) -> > "C:\U

Re: [HACKERS] forward vs backward slashes in msvc build code

2015-02-15 Thread Michael Paquier
On Sun, Feb 15, 2015 at 12:51 PM, Peter Eisentraut wrote: > I understand that on Windows, you can use forward slashes in path names > interchangeably with backward slashes (except possibly in the shell). I > have developed the attached patch to change the msvc build code to use > forward slashes

[HACKERS] forward vs backward slashes in msvc build code

2015-02-14 Thread Peter Eisentraut
I understand that on Windows, you can use forward slashes in path names interchangeably with backward slashes (except possibly in the shell). I have developed the attached patch to change the msvc build code to use forward slashes consistently. Together with the other attached patch, which is an