Re: [HACKERS] fixing PQsetvalue()

2011-07-21 Thread Robert Haas
On Thu, Jul 21, 2011 at 12:19 PM, Tom Lane wrote: > Robert Haas writes: >> So I finally got around to taking a look at this patch, and I guess my >> basic feeling is that I like it.  The existing code is pretty weird >> and inconsistent: the logic in PQsetvalue() basically does the same >> thing

Re: [HACKERS] fixing PQsetvalue()

2011-07-21 Thread Tom Lane
Robert Haas writes: > So I finally got around to taking a look at this patch, and I guess my > basic feeling is that I like it. The existing code is pretty weird > and inconsistent: the logic in PQsetvalue() basically does the same > thing as the logic in pqAddTuple(), but incompatibly and less >

Re: [HACKERS] fixing PQsetvalue()

2011-07-21 Thread Merlin Moncure
On Wed, Jul 20, 2011 at 10:28 PM, Robert Haas wrote: > On Mon, Jul 18, 2011 at 6:38 AM, Pavel Golub wrote: >> Hello, Merlin. >> >> I hope it's OK that I've added Andrew's patch to CommitFest: >> https://commitfest.postgresql.org/action/patch_view?id=606 >> >> I did this becuase beta3 already rele

Re: [HACKERS] fixing PQsetvalue()

2011-07-20 Thread Robert Haas
On Mon, Jul 18, 2011 at 6:38 AM, Pavel Golub wrote: > Hello, Merlin. > > I hope it's OK that I've added Andrew's patch to CommitFest: > https://commitfest.postgresql.org/action/patch_view?id=606 > > I did this becuase beta3 already released, but nut nothig is done on > this bug. So I finally got

Re: [HACKERS] fixing PQsetvalue()

2011-07-18 Thread Pavel Golub
Hello, Merlin. I hope it's OK that I've added Andrew's patch to CommitFest: https://commitfest.postgresql.org/action/patch_view?id=606 I did this becuase beta3 already released, but nut nothig is done on this bug. You wrote: MM> On Thu, Jun 23, 2011 at 7:54 AM, Andrew Chernow wrote: >>>    you

Re: [HACKERS] fixing PQsetvalue()

2011-07-06 Thread Pavel Golub
Hello. Any news on these issues? Becuase beta3 is scheduled for July 11th... You wrote: MM> On Jun 6 MM> (http://archives.postgresql.org/pgsql-hackers/2011-06/msg00272.php), MM> Pavel discovered an issue with PQsetvalue that could cause libpq to MM> wander off into unallocated memory that was pr

Re: [HACKERS] fixing PQsetvalue()

2011-06-23 Thread Merlin Moncure
On Thu, Jun 23, 2011 at 7:54 AM, Andrew Chernow wrote: >>    you are creating as you iterate through.  This behavior was >>    unnecessary in terms of what libpqtypes and friends needed and may (as >>    Tom suggested) come back to bite us at some point. As it turns out, >>    PQsetvalue's operati

Re: [HACKERS] fixing PQsetvalue()

2011-06-23 Thread Dmitriy Igrishin
2011/6/23 Andrew Chernow > you are creating as you iterate through. This behavior was >>unnecessary in terms of what libpqtypes and friends needed and may (as >>Tom suggested) come back to bite us at some point. As it turns out, >>PQsetvalue's operation on results that weren't cr

Re: [HACKERS] fixing PQsetvalue()

2011-06-23 Thread Andrew Chernow
you are creating as you iterate through. This behavior was unnecessary in terms of what libpqtypes and friends needed and may (as Tom suggested) come back to bite us at some point. As it turns out, PQsetvalue's operation on results that weren't created via PQmakeEmptyResult wa

Re: [HACKERS] fixing PQsetvalue()

2011-06-23 Thread Pavel Golub
Hello, Merlin. You wrote: MM> On Jun 6 MM> (http://archives.postgresql.org/pgsql-hackers/2011-06/msg00272.php), MM> Pavel discovered an issue with PQsetvalue that could cause libpq to MM> wander off into unallocated memory that was present in 9.0.x. A MM> fairly uninteresting fix was quickly pro

Re: [HACKERS] fixing PQsetvalue()

2011-06-23 Thread Dmitriy Igrishin
2011/6/23 Merlin Moncure > On Jun 6 ( > http://archives.postgresql.org/pgsql-hackers/2011-06/msg00272.php), > Pavel discovered an issue with PQsetvalue that could cause libpq to > wander off into unallocated memory that was present in 9.0.x. A > fairly uninteresting fix was quickly produced, but

[HACKERS] fixing PQsetvalue()

2011-06-22 Thread Merlin Moncure
On Jun 6 (http://archives.postgresql.org/pgsql-hackers/2011-06/msg00272.php), Pavel discovered an issue with PQsetvalue that could cause libpq to wander off into unallocated memory that was present in 9.0.x. A fairly uninteresting fix was quickly produced, but Tom indicated during subsequent revie