Re: [HACKERS] findoidjoins

2002-09-04 Thread Joe Conway
Tom Lane wrote: > Joe Conway <[EMAIL PROTECTED]> writes: >>Is it useful to have the reference count and unreferenced counts like >>currently written, or should I just faithfully reproduce the original >>behavior (except schema aware queries) using libpq in place of libpgeasy? > > I'd be incline

Re: [HACKERS] findoidjoins

2002-09-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Is it useful to have the reference count and unreferenced counts like > currently written, or should I just faithfully reproduce the original > behavior (except schema aware queries) using libpq in place of libpgeasy? I'd be inclined to reproduce the ori

Re: [HACKERS] findoidjoins

2002-09-04 Thread Bruce Momjian
Patch withdrawn by author. --- Joe Conway wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > >>Christopher Kings-Lynne dijo: > >>>findoidjoins doens't seem to compile: > >>Seems related to the rippin

Re: [HACKERS] findoidjoins

2002-09-04 Thread Joe Conway
Tom Lane wrote: > For what we want it for (viz, regenerating the oidjoins test every so > often), this is really a step backwards. It requires more work to run > than the original program, and it modifies the database under test, > which is undesirable because it's commonly run against template1.

Re: [HACKERS] findoidjoins

2002-09-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > I'm not sure I interpreted the intent of findoidjoins just right, but > here it is updated for schemas, new reg* types, using SPI instead of > libpgeasy, and returning the results as a table function. Any > corrections/comments? For what we want it for

Re: [HACKERS] findoidjoins

2002-09-03 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://207.106.42.251/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Joe Conway wrote: > Tom Lane wrote: > > Alvaro H

Re: [HACKERS] findoidjoins

2002-09-03 Thread Joe Conway
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: >>Christopher Kings-Lynne dijo: >>>findoidjoins doens't seem to compile: >>Seems related to the ripping of libpgeasy out of the main >>distribution... > > I believe it's been broken for some time (disremember just why, maybe a > schema

Re: [HACKERS] findoidjoins

2002-09-03 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Christopher Kings-Lynne dijo: >> findoidjoins doens't seem to compile: > Seems related to the ripping of libpgeasy out of the main > distribution... I believe it's been broken for some time (disremember just why, maybe a schema issue?). I had a TODO

Re: [HACKERS] findoidjoins

2002-09-02 Thread Alvaro Herrera
Christopher Kings-Lynne dijo: > findoidjoins doens't seem to compile: > > gmake[1]: Entering directory `/home/chriskl/pgsql-head/contrib/findoidjoins' > gcc -pipe -O -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../sr > c/interfaces/libpgeasy -I../../src/interfaces/libpq -I. -I../..

[HACKERS] findoidjoins

2002-09-02 Thread Christopher Kings-Lynne
findoidjoins doens't seem to compile: gmake[1]: Entering directory `/home/chriskl/pgsql-head/contrib/findoidjoins' gcc -pipe -O -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../sr c/interfaces/libpgeasy -I../../src/interfaces/libpq -I. -I../../src/include -c -o findoidjoins.o findo