Re: [HACKERS] explain refactoring v4

2009-07-24 Thread Magnus Hagander
On Fri, Jul 24, 2009 at 23:11, Robert Haas wrote: > On Fri, Jul 24, 2009 at 4:02 PM, Tom Lane wrote: >> This is not likely to matter to human readers but it might to programs. >> OTOH we presumably expect programs to migrate to using a more >> program-friendly EXPLAIN output format with 8.5. >> >>

Re: [HACKERS] explain refactoring v4

2009-07-24 Thread Robert Haas
On Fri, Jul 24, 2009 at 5:11 PM, Tom Lane wrote: > Robert Haas writes: >> OK, here it is again.  Changes are the same as the previous version, >> but this one should apply cleanly after today's pgindent run. > > Applied with some minor editorialization/further cleanup. Thanks. I mostly finished

Re: [HACKERS] explain refactoring v4

2009-07-24 Thread Robert Haas
On Fri, Jul 24, 2009 at 4:02 PM, Tom Lane wrote: > Robert Haas writes: >> OK, here it is again.  Changes are the same as the previous version, >> but this one should apply cleanly after today's pgindent run. > > As I was poking through this I noticed that it makes at least one small > change in th

Re: [HACKERS] explain refactoring v4

2009-07-24 Thread Tom Lane
Robert Haas writes: > OK, here it is again. Changes are the same as the previous version, > but this one should apply cleanly after today's pgindent run. Applied with some minor editorialization/further cleanup. I left the "Subquery Scan on ss" business as-is. If anyone complains it would be a

Re: [HACKERS] explain refactoring v4

2009-07-24 Thread Tom Lane
Robert Haas writes: > OK, here it is again. Changes are the same as the previous version, > but this one should apply cleanly after today's pgindent run. As I was poking through this I noticed that it makes at least one small change in the output format: what had been "Subquery Scan ss" will now

Re: [HACKERS] explain refactoring v4 - RR Review

2009-07-18 Thread Andres Freund
Hi Robert, Hi all, On Friday 12 June 2009 06:32:11 Robert Haas wrote: > OK, here it is again. Changes are the same as the previous version, > but this one should apply cleanly after today's pgindent run. Not much to say here. Patch applies cleanly, the changes look sensible and as far as I can s

[HACKERS] explain refactoring v4

2009-06-11 Thread Robert Haas
OK, here it is again. Changes are the same as the previous version, but this one should apply cleanly after today's pgindent run. http://archives.postgresql.org/message-id/603c8f070906051803nd4a9e3ekb72bcc379ad73...@mail.gmail.com (Rebasing this wasn't too bad, but I have to say that one thing t