Re: [HACKERS] embedded list v3

2012-10-08 Thread Andres Freund
Hi Peter, On Monday, October 08, 2012 09:43:51 PM Peter Geoghegan wrote: > Pendantry: This should be in alphabetical order: > > ! OBJS = stringinfo.o ilist.o Argh. Youve said that before. Somehow I reintroduced it... > I notice that the patch (my revision) produces a whole bunch of > warnings li

Re: [HACKERS] embedded list v3

2012-10-01 Thread Andres Freund
On Monday, October 01, 2012 05:33:01 PM Tom Lane wrote: > Andres Freund writes: > > On Sunday, September 30, 2012 10:33:28 PM Tom Lane wrote: > >> I'm still pretty desperately unhappy with your insistence on circularly > >> linked dlists. Not only does that make initialization problematic, > >> bu

Re: [HACKERS] embedded list v3

2012-10-01 Thread Tom Lane
Andres Freund writes: > On Sunday, September 30, 2012 10:33:28 PM Tom Lane wrote: >> I'm still pretty desperately unhappy with your insistence on circularly >> linked dlists. Not only does that make initialization problematic, >> but now it's not even consistent with slists. > We literally have t

Re: [HACKERS] embedded list v3

2012-10-01 Thread Peter Eisentraut
On 9/30/12 5:42 PM, Andres Freund wrote: > I thought msvc supported _Static_assert as well, but after a short search it > seems I misremembered and it only supports static_assert from C++11 (which is > plausible, because I've worked on a C++11 project which was ported to windows > ). I don't kno

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
On Sunday, September 30, 2012 10:48:01 PM Tom Lane wrote: > Andres Freund writes: > > Perhaps we need to decouple _Static_assert support from compound > > statement support at some point, but we will see. > > Yeah, possibly, but until we have an example of a non-gcc-compatible > compiler that can

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
Hi, On Sunday, September 30, 2012 10:33:28 PM Tom Lane wrote: > Andres Freund writes: > > Current version is available at branch ilist in: > > git://git.postgresql.org/git/users/andresfreund/postgres.git > > ssh://g...@git.postgresql.org/users/andresfreund/postgres.git > > I'm still pretty despe

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund writes: > Perhaps we need to decouple _Static_assert support from compound statement > support at some point, but we will see. Yeah, possibly, but until we have an example of a non-gcc-compatible compiler that can do something equivalent, it's hard to guess how we might need to alt

Re: [HACKERS] embedded list v3

2012-09-30 Thread Andres Freund
On Sunday, September 30, 2012 06:57:32 PM Tom Lane wrote: > Andres Freund writes: > > Patch 0001 contains a assert_compatible_types(a, b) and a > > assert_compatible_types_bool(a, b) macro which I found very useful to > > make it harder to misuse the api. I think its generally useful and > > possi

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund writes: > Current version is available at branch ilist in: > git://git.postgresql.org/git/users/andresfreund/postgres.git > ssh://g...@git.postgresql.org/users/andresfreund/postgres.git I'm still pretty desperately unhappy with your insistence on circularly linked dlists. Not only

Re: [HACKERS] embedded list v3

2012-09-30 Thread Tom Lane
Andres Freund writes: > Patch 0001 contains a assert_compatible_types(a, b) and a > assert_compatible_types_bool(a, b) macro which I found very useful to make it > harder to misuse the api. I think its generally useful and possibly should be > used in more places. This seems like basically a goo

Re: [HACKERS] embedded list v3

2012-09-28 Thread Andres Freund
> Add [ds]list's which can be used to embed lists in bigger data structures > without additional memory management > Alvaro, Andres, Review by Peter G. and Tom This is missing Robert. Sorry for that. Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Develop