Re: [HACKERS] ecpg localization

2008-05-17 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > I mean that you need to put and setlocale(LC_MESSAGES, "") at > .pgc so you get localized messages from ecpg program. That seems perfectly reasonable. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: h

Re: [HACKERS] ecpg localization

2008-05-16 Thread Euler Taveira de Oliveira
Peter Eisentraut wrote: I forgot to say that this patch doesn't include nls support to ecpg files automagically. If you guys think that it's is a Good Thing to do, we need to hack the preproc.y to hardcode the locale stuff; if you decide that it isn't necessary, we need to document that the nls

Re: [HACKERS] ecpg localization

2008-05-16 Thread Peter Eisentraut
Am Sonntag, 11. Mai 2008 schrieb Euler Taveira de Oliveira: > I forgot to say that this patch doesn't include nls support to ecpg > files automagically. If you guys think that it's is a Good Thing to do, > we need to hack the preproc.y to hardcode the locale stuff; if you > decide that it isn't nec

Re: [HACKERS] ecpg localization

2008-05-16 Thread Peter Eisentraut
Am Samstag, 10. Mai 2008 schrieb Euler Taveira de Oliveira: > This is a second try. Fix some issues pointed by Peter. It's a little > fatter 'cause I worked on almost all of the strings. I attempted to > mimic the postgresql style but I think that those strings need more work > on as I pointed out

Re: [HACKERS] ecpg localization

2008-05-10 Thread Euler Taveira de Oliveira
Euler Taveira de Oliveira wrote: This is a second try. I forgot to say that this patch doesn't include nls support to ecpg files automagically. If you guys think that it's is a Good Thing to do, we need to hack the preproc.y to hardcode the locale stuff; if you decide that it isn't necessar

Re: [HACKERS] ecpg localization

2008-05-10 Thread Euler Taveira de Oliveira
Peter Eisentraut wrote: I suggest you keep working on this, and we will reconsider a more complete patch at a later date. This is a second try. Fix some issues pointed by Peter. It's a little fatter 'cause I worked on almost all of the strings. I attempted to mimic the postgresql style but I

Re: [HACKERS] ecpg localization

2008-05-06 Thread Michael Meskes
On Fri, May 02, 2008 at 07:19:00PM -0400, Tom Lane wrote: > Ultimately Michael's opinion is the one that matters most for ecpg > stuff, anyway. Michael? Sorry for the late reply, real life constraints. I talked to Peter about the patched before he sent out his first email. In fact I agree with bo

Re: [HACKERS] ecpg localization

2008-05-03 Thread Peter Eisentraut
Tom Lane wrote: > I'm wondering whether it would be appropriate to apply now despite being > incomplete.  The patch touches enough places in ecpg that code drift is > likely to be a serious problem if it has to sit around for long. We could do that, as soon as the author understands where the patc

Re: [HACKERS] ecpg localization

2008-05-03 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > I don't know if I understand what you want to say by "call gettext". A > quick look at the l10n of backend proves that it calls gettext > everywhere. Could you ellaborate? In nls.mk, you mark mmerror as containing arguments for translation, but mmerror doesn't c

Re: [HACKERS] ecpg localization

2008-05-02 Thread Euler Taveira de Oliveira
Peter Eisentraut wrote: Looks good for a start, but what is missing in this patch is that mmerror and the other functions actually call gettext. So currently this patch doesn't achieve a lot. I don't know if I understand what you want to say by "call gettext". A quick look at the l10n of ba

Re: [HACKERS] ecpg localization

2008-05-02 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Samstag, 26. April 2008 schrieb Euler Taveira de Oliveira: >> One of the few parts of the core that is not localized is the ecpg. >> Attached is a patch that builds the basic infrastructure to make it >> possible. > Looks good for a start, but what

Re: [HACKERS] ecpg localization

2008-05-02 Thread Peter Eisentraut
Am Samstag, 26. April 2008 schrieb Euler Taveira de Oliveira: > One of the few parts of the core that is not localized is the ecpg. > Attached is a patch that builds the basic infrastructure to make it > possible. Besides that I worked on some strings to make them conform > with [1] but I didn't do

[HACKERS] ecpg localization

2008-04-25 Thread Euler Taveira de Oliveira
Hi, One of the few parts of the core that is not localized is the ecpg. Attached is a patch that builds the basic infrastructure to make it possible. Besides that I worked on some strings to make them conform with [1] but I didn't do for all of them. When I was doing the clean up I realized th