Re: [HACKERS] dump a comment of a TSDictionary

2017-03-07 Thread Giuseppe Broccolo
Hi, 2017-03-07 1:40 GMT+01:00 Tom Lane : > > This is actually a problem if a new TSDictionary is created, in a > different > > schema specified by the dumped search_path setting. > > Just out of curiosity, do you have a concrete test case where it failed > that way? AFAICS the emitted SQL would

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Tom Lane
Giuseppe Broccolo writes: > I've seen that pg_dump execute the dump of an eventual comment of a > TSDictionary without specifying the namespace where it is defined: > https://github.com/postgres/postgres/blob/master/src/bin/pg_dump/pg_dump.c#L13542 Yup, this is clearly an error --- thanks for spo

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Do you want to deal with this whole mess, or shall I have a go at it? > > > I'm just about to push the pg_upgrade fixes for large object comments > > and security labels, followed not to

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Do you want to deal with this whole mess, or shall I have a go at it? > I'm just about to push the pg_upgrade fixes for large object comments > and security labels, followed not too far behind by the fix for the > public ACL in pg_

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Giuseppe Broccolo (giuseppe.brocc...@2ndquadrant.it) wrote: > >> I've seen that pg_dump execute the dump of an eventual comment of a > >> TSDictionary without specifying the namespace where it is defined: > > > Great catch! > >

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Tom Lane
Stephen Frost writes: > * Giuseppe Broccolo (giuseppe.brocc...@2ndquadrant.it) wrote: >> I've seen that pg_dump execute the dump of an eventual comment of a >> TSDictionary without specifying the namespace where it is defined: > Great catch! One of my smarter CS professors taught me that wheneve

Re: [HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Stephen Frost
Greeting,s * Giuseppe Broccolo (giuseppe.brocc...@2ndquadrant.it) wrote: > I've seen that pg_dump execute the dump of an eventual comment of a > TSDictionary without > specifying the namespace where it is defined: Great catch! > This is actually a problem if a new TSDictionary is created, in a d

[HACKERS] dump a comment of a TSDictionary

2017-03-06 Thread Giuseppe Broccolo
Hi hackers, I've seen that pg_dump execute the dump of an eventual comment of a TSDictionary without specifying the namespace where it is defined: https://github.com/postgres/postgres/blob/master/src/bin/pg_dump/pg_dump.c#L13542 This is actually a problem if a new TSDictionary is created, in a d