Re: [HACKERS] drop tablespace error: invalid argument

2009-11-10 Thread Tom Lane
Stephen Tyler writes: > On Tue, Nov 10, 2009 at 8:57 PM, Jan Otto wrote: >>> Someone else please confirm? If so I'll revert that patch. >> >> Yes i can confirm that this bug is fixed in Mac OS X 10.6.2. I have checked >> it twice. >> With removed workaround in tablespace.c and with my self writ

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-10 Thread Stephen Tyler
On Tue, Nov 10, 2009 at 8:57 PM, Jan Otto wrote: > > Someone else please confirm? If so I'll revert that patch. > > Yes i can confirm that this bug is fixed in Mac OS X 10.6.2. I have checked > it twice. > With removed workaround in tablespace.c and with my self written testcase > from > septemb

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-10 Thread Jan Otto
>> My inclination is to continue assuming that the EINVAL is a new bug >> introduced in Snow Leopard. I sure hope they fix it in 10.6.2 though. >> If they don't, we may have to think about a workaround, messy as that >> will apparently be. > > 10.6.2 is out, and it appears to fix the bug --- if I

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-09 Thread Tom Lane
I wrote: > My inclination is to continue assuming that the EINVAL is a new bug > introduced in Snow Leopard. I sure hope they fix it in 10.6.2 though. > If they don't, we may have to think about a workaround, messy as that > will apparently be. 10.6.2 is out, and it appears to fix the bug --- if

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-09 Thread Tom Lane
Jan Otto writes: > a quick check on mac os x 10.4 und 10.5 confirmed that this behaviour/ > bug is not present like described in this article. probably it was in > 10.0.x... i have no older version of mac os x available here to check. Yeah, I thought we'd probably have heard about it before now i

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-09 Thread Jan Otto
Hey Jan, did you get any response to that bug report? Somebody else dug up a document suggesting that this might be intentional on Apple's part: http://archives.postgresql.org/pgsql-bugs/2009-11/msg00040.php i was not subscribed to pgsql-bugs list. i have read this message now and see he is r

Re: [HACKERS] drop tablespace error: invalid argument

2009-11-09 Thread Jan Otto
ERROR: could not read directory "pg_tblspc/16464": Invalid argument STATEMENT: DROP TABLESPACE testspace; Hmm ... can't reproduce this here, not even on OSX. From the version number I suspect you are using unreleased Snow Leopard. I'd venture it's a newly-introduced kernel bug and you n

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-12 Thread Jan Otto
Well, 10.6.1 is out and it's still got the readdir() bug :-(. Has someone filed a bug report about this with Apple? yes i have filed a bugreport and keep this list informed when there is something going on. regards, jan otto -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.o

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-12 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > I've applied this patch in HEAD only for the moment. I hope that > Apple will have fixed their bug before the next set of PG back-branch > updates come out --- if not, we'll probably have to back-patch. and on the flip side, I was hoping to see a new 8.4.2

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-12 Thread Tom Lane
Jan Otto writes: > This patch basically frees dirdesc and rereads the tablespace location > in case a subdirectory was deleted from the tablespace. this is the > place > where snow leopard fails to read the next entry with readdir(). I've applied this patch in HEAD only for the moment. I hope

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-11 Thread Robert Creager
On Sep 11, 2009, at 2:35 PM, David E. Wheeler wrote: On Sep 11, 2009, at 12:42 PM, Tom Lane wrote: Well, 10.6.1 is out and it's still got the readdir() bug :-(. Has someone filed a bug report about this with Apple? https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa Look at th

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-11 Thread Robert Creager
On Sep 11, 2009, at 2:35 PM, David E. Wheeler wrote: On Sep 11, 2009, at 12:42 PM, Tom Lane wrote: Well, 10.6.1 is out and it's still got the readdir() bug :-(. Has someone filed a bug report about this with Apple? https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa If no one

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-11 Thread David E. Wheeler
On Sep 11, 2009, at 12:42 PM, Tom Lane wrote: Well, 10.6.1 is out and it's still got the readdir() bug :-(. Has someone filed a bug report about this with Apple? https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa Best, David -- Sent via pgsql-hackers mailing list (pgsql-hacke

Re: [HACKERS] drop tablespace error: invalid argument

2009-09-11 Thread Tom Lane
I wrote: > Jan Otto writes: >> The bug in readdir() appeared in the final snow leopard too. Anybody >> with Snow Leopard installed can check this, with simply doing the >> regression tests (make check). The tablespace regression test is >> failing. >> The patch i sent in works around the issue. i

Re: [HACKERS] drop tablespace error: invalid argument

2009-08-30 Thread Tom Lane
Jan Otto writes: > The bug in readdir() appeared in the final snow leopard too. Anybody > with Snow Leopard installed can check this, with simply doing the > regression tests (make check). The tablespace regression test is > failing. > The patch i sent in works around the issue. if it is not acce

Re: [HACKERS] drop tablespace error: invalid argument

2009-08-30 Thread Jan Otto
Jan Otto writes: ERROR: could not read directory "pg_tblspc/16464": Invalid argument STATEMENT: DROP TABLESPACE testspace; I have digged a bit around in the source code of postgresql to build a self contained test-case for Apple and found that the implementation of Apples readdir() is buggy.

Re: [HACKERS] drop tablespace error: invalid argument

2009-08-17 Thread Jan Otto
On Aug 16, 2009, at 8:25 PM, Tom Lane wrote: Jan Otto writes: ERROR: could not read directory "pg_tblspc/16464": Invalid argument STATEMENT: DROP TABLESPACE testspace; Hmm ... can't reproduce this here, not even on OSX. From the version number I suspect you are using unreleased Snow Leopar

Re: [HACKERS] drop tablespace error: invalid argument

2009-08-16 Thread Jan Otto
ERROR: could not read directory "pg_tblspc/16464": Invalid argument STATEMENT: DROP TABLESPACE testspace; Hmm ... can't reproduce this here, not even on OSX. From the version number I suspect you are using unreleased Snow Leopard. I'd venture it's a newly-introduced kernel bug and you need t

Re: [HACKERS] drop tablespace error: invalid argument

2009-08-16 Thread Tom Lane
Jan Otto writes: > ERROR: could not read directory "pg_tblspc/16464": Invalid argument > STATEMENT: DROP TABLESPACE testspace; Hmm ... can't reproduce this here, not even on OSX. From the version number I suspect you are using unreleased Snow Leopard. I'd venture it's a newly-introduced kerne

[HACKERS] drop tablespace error: invalid argument

2009-08-16 Thread Jan Otto
hello hackers, i have problems dropping an existing empty tablespace. here is a reduced example: AscheMobil:~ asche$ cat test2.sql CREATE TABLESPACE testspace LOCATION '/opt/postgresql/data2'; CREATE SCHEMA testschema; CREATE TABLE testschema.foobar (id int) TABLESPACE testspace; DROP SCHEMA