Re: [HACKERS] create opclass documentation outdated

2016-03-10 Thread Alvaro Herrera
Alvaro Herrera wrote: > Hmm, but if we ever add support for other types in inclusion as you > describe, we will need STORAGE, no? I think it's unfortunate that the > code currently uses the field where it's not really necessary, but > harmless; if people break their systems by introducing bogus o

Re: [HACKERS] create opclass documentation outdated

2016-03-10 Thread Alvaro Herrera
Emre Hasegeli wrote: > >> In create_opclass.sgml, not only do we have the list of AMs supporting > >> STORAGE, but there is also a paragraph describing which AMs do what > >> for input datatypes of FUNCTION members (around line 175). > > > > I placed BRIN together with gist/gin/spgist here, namely

Re: [HACKERS] create opclass documentation outdated

2016-03-10 Thread Emre Hasegeli
>> In create_opclass.sgml, not only do we have the list of AMs supporting >> STORAGE, but there is also a paragraph describing which AMs do what >> for input datatypes of FUNCTION members (around line 175). > > I placed BRIN together with gist/gin/spgist here, namely that the optype > defaults to t

Re: [HACKERS] create opclass documentation outdated

2016-03-02 Thread Alvaro Herrera
Tom Lane wrote: > In create_opclass.sgml, not only do we have the list of AMs supporting > STORAGE, but there is also a paragraph describing which AMs do what > for input datatypes of FUNCTION members (around line 175). I placed BRIN together with gist/gin/spgist here, namely that the optype defa

Re: [HACKERS] create opclass documentation outdated

2016-03-02 Thread Alvaro Herrera
Tom Lane wrote: > I'm inclined to feel that the right answer is to fix all these > omissions, not to decide that we're not maintaining this documentation > anymore. Alvaro, I think this one's in your court. Will fix. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Devel

Re: [HACKERS] create opclass documentation outdated

2016-02-29 Thread Tom Lane
Julien Rouhaud writes: > On 25/02/2016 23:12, Vik Fearing wrote: >> On 02/25/2016 09:13 PM, Julien Rouhaud wrote: >>> I just saw that the CREATE OPERATOR CLASS documentation doesn't >>> mention that BRIN indexes also support the STORAGE parameter. >> I think this is the wrong approach; that paren

Re: [HACKERS] create opclass documentation outdated

2016-02-25 Thread Julien Rouhaud
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 25/02/2016 23:12, Vik Fearing wrote: > On 02/25/2016 09:13 PM, Julien Rouhaud wrote: >> Hello, >> >> I just saw that the CREATE OPERATOR CLASS documentation doesn't >> mention that BRIN indexes also support the STORAGE parameter. > > Good catch! >

Re: [HACKERS] create opclass documentation outdated

2016-02-25 Thread Vik Fearing
On 02/25/2016 09:13 PM, Julien Rouhaud wrote: > Hello, > > I just saw that the CREATE OPERATOR CLASS documentation doesn't mention > that BRIN indexes also support the STORAGE parameter. Good catch! > Patch attached. I think this is the wrong approach; that parenthetical list now represents a f

[HACKERS] create opclass documentation outdated

2016-02-25 Thread Julien Rouhaud
Hello, I just saw that the CREATE OPERATOR CLASS documentation doesn't mention that BRIN indexes also support the STORAGE parameter. Patch attached. Regards -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/create_opclass.sgml b/doc/src/sgml/ref/create_opclas