Bernd Helmle wrote:
Here is a slightly updated version of the patch. I did some (very
minor) editing on the wording in the docs and cleaned a merge conflict
in tablecmds.c. I saw no code issues so far, make check passes without
errors. Maybe someone with more bison skills can comment on the
--On Donnerstag, Mai 07, 2009 12:57:56 +0200 Andres Freund
wrote:
Ok, fixed that place (stupid me, I had seen that it is used there and
forgot about it) and found no other places.
Thanks,
Andres
Here is a slightly updated version of the patch. I did some (very minor)
editing on the wordin
Hi Tom, hi all,
On 05/06/2009 11:43 PM, Tom Lane wrote:
Andres Freund writes:
As this is my first patch to PG I am happy with most sort of feedback.
Please add your patch to the commit-fest queue here:
http://wiki.postgresql.org/wiki/CommitFestInProgress
Will do so, after this email has arri
Andres Freund writes:
> As this is my first patch to PG I am happy with most sort of feedback.
Please add your patch to the commit-fest queue here:
http://wiki.postgresql.org/wiki/CommitFestInProgress
Since we are still busy with 8.4 beta, it's unlikely that anyone will
take a close look until t
Hi,
On 05/04/2009 04:10 PM, Andres Freund wrote:
Would a patch adding 'IF EXISTS' support to:
- ALTER TABLE ... DROP COLUMN
- ALTER TABLE ... DROP CONSTRAINT
possibly be accepted?
A first version of a patch is attached:
- allows [ IF EXISTS ] for both, conditional dropping of columns and
const
Robert Haas wrote:
On Tue, May 5, 2009 at 8:56 AM, Andrew Dunstan wrote:
We have debated CREATE ... IF NOT EXISTS in the past, and there is no
consensus on what it should do, so we don't have it for any command. That is
quite a different case from what's being asked for, and the two should
Robert Haas writes:
> On Tue, May 5, 2009 at 8:56 AM, Andrew Dunstan wrote:
>> We have debated CREATE ... IF NOT EXISTS in the past, and there is no
>> consensus on what it should do, so we don't have it for any command. That is
>> quite a different case from what's being asked for, and the two s
On Tue, May 5, 2009 at 8:56 AM, Andrew Dunstan wrote:
> We have debated CREATE ... IF NOT EXISTS in the past, and there is no
> consensus on what it should do, so we don't have it for any command. That is
> quite a different case from what's being asked for, and the two should not
> be conflated.
Hi Chris,
On 05/04/2009 09:21 PM, Chris Browne wrote:
robertmh...@gmail.com (Robert Haas) writes:
On Mon, May 4, 2009 at 10:10 AM, Andres Freund wrote:
Would a patch adding 'IF EXISTS' support to:
- ALTER TABLE ... DROP COLUMN
- ALTER TABLE ... DROP CONSTRAINT
possibly be accepted?
Can't spe
Chris Browne wrote:
For columns, I'd *much* more frequently be interested in
ALTER TABLE ... ADD COLUMN IF NOT EXISTS ...
We have debated CREATE ... IF NOT EXISTS in the past, and there is no
consensus on what it should do, so we don't have it for any command.
That is quite a differ
On Monday 04 May 2009 22:21:10 Chris Browne wrote:
> For constraints, it's easy enough to treat that as idempotent; it's no
> big deal to drop and re-add a constraint.
Not if the constraint is a primary key, for example.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To m
robertmh...@gmail.com (Robert Haas) writes:
> On Mon, May 4, 2009 at 10:10 AM, Andres Freund wrote:
>> Would a patch adding 'IF EXISTS' support to:
>> - ALTER TABLE ... DROP COLUMN
>> - ALTER TABLE ... DROP CONSTRAINT
>> possibly be accepted?
>>
>> Having it makes the annoying task of writing/test
On Mon, May 4, 2009 at 10:10 AM, Andres Freund wrote:
> Would a patch adding 'IF EXISTS' support to:
> - ALTER TABLE ... DROP COLUMN
> - ALTER TABLE ... DROP CONSTRAINT
> possibly be accepted?
>
> Having it makes the annoying task of writing/testing of schema-upgrade
> scripts a bit easier.
Can't
Hi,
Would a patch adding 'IF EXISTS' support to:
- ALTER TABLE ... DROP COLUMN
- ALTER TABLE ... DROP CONSTRAINT
possibly be accepted?
Having it makes the annoying task of writing/testing of schema-upgrade
scripts a bit easier.
Andres
--
Sent via pgsql-hackers mailing list (pgsql-hackers@pos
On 05/04/2009 04:10 PM, Andres Freund wrote:
Would a patch adding 'IF EXISTS' support to:
- ALTER TABLE ... DROP COLUMN
- ALTER TABLE ... DROP CONSTRAINT
possibly be accepted?
Having it makes the annoying task of writing/testing of schema-upgrade
scripts a bit easier.
Oh, and to any other sensi
15 matches
Mail list logo
