Re: [HACKERS] cleaning up plperl warnings

2006-01-09 Thread Andrew Dunstan
Bruce Momjian wrote: Why do we need these defines at all? We don't use either of these types anywhere in the plperl code. Is the community perl different in what it does here from what the ActiveState perl? No idea, but if you don't need them, remove them so they work on your setup,

Re: [HACKERS] cleaning up plperl warnings

2006-01-09 Thread Bruce Momjian
Andrew Dunstan wrote: > Now, in src/include/port/win32.h we have this: > > /* > * Supplement to . > * > * Perl already has conflicting defines for uid_t and gid_t. > */ > #ifndef PLPERL_HAVE_UID_GID > typedef int uid_t; > typedef int gid_t; > #else > /* These are redefined by perl. */ > #defin

[HACKERS] cleaning up plperl warnings

2006-01-08 Thread Andrew Dunstan
First, I cleaned up many of the warnings on my Windows box by running this to fix up comments in perl's config.h: sed -i -e 's,\(^/\*.*\)/\*,\1/ *,' config.h unix2dos config.h That puts a space between the / and * of what would otherwise be an embedded comment start, and thus removes