Re: [HACKERS] btreecheck extension

2015-10-07 Thread Peter Geoghegan
On Wed, Oct 7, 2015 at 2:59 AM, Bernd Helmle wrote: > What's the current state of this module? I see you are interested in stress > testing, but i'm not sure how far this all is gone? > > This tool actually served a very good job during identifying index > corruption due to collation issues[1]. I

Re: [HACKERS] btreecheck extension

2015-10-07 Thread Bernd Helmle
--On 16. Juni 2014 18:47:30 -0700 Peter Geoghegan wrote: > Attached prototype patch adds contrib extension, btreecheck. This > extension provides SQL-callable functions for checking these > conditions on nbtree indexes on live systems. What's the current state of this module? I see you are int

Re: [HACKERS] btreecheck extension

2014-06-18 Thread Peter Geoghegan
On Wed, Jun 18, 2014 at 4:48 AM, Stephen Frost wrote: > I'm fine with having these start out as external tools which are doing > checks, but I've been specifically asked about (and have desired myself > from time-to-time...) an in-core capability to check index/heap/etc > validity. Folks coming f

Re: [HACKERS] btreecheck extension

2014-06-18 Thread Stephen Frost
* Peter Geoghegan (p...@heroku.com) wrote: > On Tue, Jun 17, 2014 at 5:11 PM, Robert Haas wrote: > > Now, we could. We could come up with an extensible syntax, like this: > > > > CHECK relation [ USING { checktype [ '(' arg [, ...] '}' [, ...] ]; > > That's what I had in mind. Using the same tri

Re: [HACKERS] btreecheck extension

2014-06-17 Thread Peter Geoghegan
On Tue, Jun 17, 2014 at 5:11 PM, Robert Haas wrote: > I think there's something to be said for that, but I think at the > moment I like the idea of a functional interface better. The reason > is that I'm not sure we can predict all of the checks we're going to > want to add. That's true. Clearly

Re: [HACKERS] btreecheck extension

2014-06-17 Thread Robert Haas
On Tue, Jun 17, 2014 at 5:10 PM, Peter Geoghegan wrote: > On Tue, Jun 17, 2014 at 1:16 PM, Robert Haas wrote: >> I don't feel qualified to comment on any of the substantive issues you >> raise, so instead I'd like to bikeshed the name. I suggest that we >> create one extension to be a repository

Re: [HACKERS] btreecheck extension

2014-06-17 Thread Peter Geoghegan
On Tue, Jun 17, 2014 at 1:16 PM, Robert Haas wrote: > I don't feel qualified to comment on any of the substantive issues you > raise, so instead I'd like to bikeshed the name. I suggest that we > create one extension to be a repository for index-checking machinery > (and perhaps also heap-checkin

Re: [HACKERS] btreecheck extension

2014-06-17 Thread Robert Haas
On Mon, Jun 16, 2014 at 9:47 PM, Peter Geoghegan wrote: > As discussed at the developer meeting at pgCon, I think that there is > a lot to be said for a tool that checks nbtree index invariants on > live systems. Me too. > Attached prototype patch adds contrib extension, btreecheck. I don't fee

[HACKERS] btreecheck extension

2014-06-16 Thread Peter Geoghegan
As discussed at the developer meeting at pgCon, I think that there is a lot to be said for a tool that checks nbtree index invariants on live systems. Attached prototype patch adds contrib extension, btreecheck. This extension provides SQL-callable functions for checking these conditions on nbtree