Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-06-04 Thread Tom Lane
Andres Freund writes: > On 2014-05-14 12:20:55 -0400, Tom Lane wrote: >> Yeah, I don't think we want to bump the WAL version code post-beta1. >> >> Probably better to assign the modified spgist record a new xl_info ID >> number, so that a beta1 slave would throw an error for it. > Since that shi

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-06-04 Thread Andres Freund
On 2014-05-14 12:20:55 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2014-05-14 10:07:18 -0400, Tom Lane wrote: > >> I think that's an OK restriction as long as we warn people about it > >> (you could update a replication pair as long as you shut them both > >> down cleanly at the same tim

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-14 Thread Tom Lane
Andres Freund writes: > On 2014-05-14 10:07:18 -0400, Tom Lane wrote: >> I think that's an OK restriction as long as we warn people about it >> (you could update a replication pair as long as you shut them both >> down cleanly at the same time, right?). Can the WAL replay routine >> be made to de

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-14 Thread Andres Freund
On 2014-05-14 10:07:18 -0400, Tom Lane wrote: > Heikki Linnakangas writes: > > On 05/13/2014 05:13 PM, Andres Freund wrote: > >> What's your plans with your spgist fix? Commit it once 9.5 is branched? > > > Good question. I don't know. I would still like to commit it to 9.4. It > > doesn't requi

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-14 Thread Tom Lane
Heikki Linnakangas writes: > On 05/13/2014 05:13 PM, Andres Freund wrote: >> What's your plans with your spgist fix? Commit it once 9.5 is branched? > Good question. I don't know. I would still like to commit it to 9.4. It > doesn't require catalog changes, but it's an incompatible change in the

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-14 Thread Andres Freund
On 2014-05-14 14:55:38 +0300, Heikki Linnakangas wrote: > On 05/13/2014 05:13 PM, Andres Freund wrote: > >That leaves the spgist thing and some infrastructure till we can setup a > >valgrind animal... From what we've caught with it so far that seems > >rather worthwile. > >What's your plans with yo

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-14 Thread Heikki Linnakangas
On 05/13/2014 05:13 PM, Andres Freund wrote: That leaves the spgist thing and some infrastructure till we can setup a valgrind animal... From what we've caught with it so far that seems rather worthwile. What's your plans with your spgist fix? Commit it once 9.5 is branched? Good question. I do

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-13 Thread Andres Freund
On 2014-05-13 15:33:08 +0300, Heikki Linnakangas wrote: > On 05/06/2014 10:03 PM, Andres Freund wrote: > >Hi, > > > >I am not sure whether these are new for 9.4 but they're worth looking at > >anyway: > >Valgrind was run with: > > --trace-children=yes --quiet \ > > --track-origins=yes --leak-chec

Re: [HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-13 Thread Heikki Linnakangas
On 05/06/2014 10:03 PM, Andres Freund wrote: Hi, I am not sure whether these are new for 9.4 but they're worth looking at anyway: Valgrind was run with: --trace-children=yes --quiet \ --track-origins=yes --leak-check=no \ --read-var-info=yes \ --suppressions=/home/andres/src/postgresql/s

[HACKERS] btree_gist valgrind warnings about uninitialized memory

2014-05-06 Thread Andres Freund
Hi, I am not sure whether these are new for 9.4 but they're worth looking at anyway: Valgrind was run with: --trace-children=yes --quiet \ --track-origins=yes --leak-check=no \ --read-var-info=yes \ --suppressions=/home/andres/src/postgresql/src/tools/valgrind.supp \ All seem to be due btree