Re: [HACKERS] back branches vs. VS 2008

2011-01-04 Thread Andrew Dunstan
On 01/04/2011 04:43 AM, Magnus Hagander wrote: OK, what's going here is that, in the newer SDK, IPV6_V6ONLY is defined unconditionally, but IPPROTO_IPV6 is only defined if _WIN32_WINNT is set to 0x0501 or higher. We defined _WIN32_WINNT as 0x0500 until 9.0, when we changed it specifically to

Re: [HACKERS] back branches vs. VS 2008

2011-01-04 Thread Magnus Hagander
On Tue, Jan 4, 2011 at 04:49, Andrew Dunstan wrote: > > On 01/03/2011 12:15 PM, I wrote: >> >> The following patch allows me to build the 8.3 and 8.4 branches using >> Visual Studio 2008, once the build system is patched. But I don't really >> know why. HEAD and 9.0 build fine without it. But thos

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Andrew Dunstan
On 01/03/2011 12:15 PM, I wrote: The following patch allows me to build the 8.3 and 8.4 branches using Visual Studio 2008, once the build system is patched. But I don't really know why. HEAD and 9.0 build fine without it. But those branches branches fail with a complaint about IPPROTO_IPV6

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Dave Page
On Mon, Jan 3, 2011 at 8:04 PM, Tom Lane wrote: > Dave Page writes: >> On Mon, Jan 3, 2011 at 6:50 PM, Tom Lane wrote: >>> Magnus Hagander writes: And we're not going to be changing the version that's actually used for the official binary builds, so all you'll accomplish then is to >>

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Tom Lane
Andrew Dunstan writes: > But more importantly, the buildfarm is about more than just "official > build platform" support. Agreed, we should be testing as many build platforms as possible. I was just concerned about whether we were losing any coverage. regards, tom lane

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Andrew Dunstan
On 01/03/2011 03:04 PM, Tom Lane wrote: Dave Page writes: On Mon, Jan 3, 2011 at 6:50 PM, Tom Lane wrote: Magnus Hagander writes: And we're not going to be changing the version that's actually used for the official binary builds, so all you'll accomplish then is to have the buildfarm test

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Tom Lane
Dave Page writes: > On Mon, Jan 3, 2011 at 6:50 PM, Tom Lane wrote: >> Magnus Hagander writes: >>> And we're not going to be changing the version that's actually used >>> for the official binary builds, so all you'll accomplish then is to >>> have the buildfarm test something different form what

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Dave Page
On Mon, Jan 3, 2011 at 6:50 PM, Tom Lane wrote: > Magnus Hagander writes: >> On Mon, Jan 3, 2011 at 19:08, Andrew Dunstan wrote: >>> I'm not going to maintain more than one buildfarm member doing MSVC, and and >>> if we were to adopt your policy I would not be able to use a modern-ish >>> versio

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Robert Haas
On Mon, Jan 3, 2011 at 2:23 PM, Andrew Dunstan wrote: > Incidentally, I just went looking for VS2005/Express on microsoft.com. I > don't know if they still make it available, but if they do it's fairly well > hidden. I could find VS2008/Express and VS2010/Express very easily. ISTM > that having su

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Andrew Dunstan
On 01/03/2011 01:50 PM, Tom Lane wrote: It might be reasonable to argue that this particular patch is too invasive to be safe to back-patch, but I don't agree with the premise that it isn't a reasonable topic for a back-patch. The patch for the non-buildsystem code is one line. The rest is a

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 19:50, Tom Lane wrote: > Magnus Hagander writes: >> On Mon, Jan 3, 2011 at 19:08, Andrew Dunstan wrote: >>> I'm not going to maintain more than one buildfarm member doing MSVC, and and >>> if we were to adopt your policy I would not be able to use a modern-ish >>> version

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Tom Lane
Magnus Hagander writes: > On Mon, Jan 3, 2011 at 19:08, Andrew Dunstan wrote: >> I'm not going to maintain more than one buildfarm member doing MSVC, and and >> if we were to adopt your policy I would not be able to use a modern-ish >> version of the compiler/SDK and also build all the live branc

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 19:08, Andrew Dunstan wrote: > > > On 01/03/2011 12:43 PM, Magnus Hagander wrote: >> >> On Mon, Jan 3, 2011 at 18:15, Andrew Dunstan  wrote: >>> >>> The following patch allows me to build the 8.3 and 8.4 branches using >>> Visual >>> Studio 2008, once the build system is pat

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Andrew Dunstan
On 01/03/2011 12:43 PM, Magnus Hagander wrote: On Mon, Jan 3, 2011 at 18:15, Andrew Dunstan wrote: The following patch allows me to build the 8.3 and 8.4 branches using Visual Studio 2008, once the build system is patched. But I don't really know why. HEAD and 9.0 build fine without it. But t

Re: [HACKERS] back branches vs. VS 2008

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 18:15, Andrew Dunstan wrote: > > The following patch allows me to build the 8.3 and 8.4 branches using Visual > Studio 2008, once the build system is patched. But I don't really know why. > HEAD and 9.0 build fine without it. But those branches branches fail with a > complai

[HACKERS] back branches vs. VS 2008

2011-01-03 Thread Andrew Dunstan
The following patch allows me to build the 8.3 and 8.4 branches using Visual Studio 2008, once the build system is patched. But I don't really know why. HEAD and 9.0 build fine without it. But those branches branches fail with a complaint about IPPROTO_IPV6 being undefined. The patch seems h