On 2017-09-18 09:54:52 -0400, Peter Eisentraut wrote:
> On 9/16/17 08:10, David Steele wrote:
> >>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly
> >>> designed, and too obsolete crypto-wise, to be useful or supportable.
> >> crypt() uses the 7 lowest characters, which mak
On 9/18/17 09:54, Peter Eisentraut wrote:
> On 9/16/17 08:10, David Steele wrote:
(5) drop contrib/chkpass altogether, on the grounds that it's too badly
designed, and too obsolete crypto-wise, to be useful or supportable.
>>> crypt() uses the 7 lowest characters, which makes for 7.2e16 v
On 9/16/17 08:10, David Steele wrote:
>>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly
>>> designed, and too obsolete crypto-wise, to be useful or supportable.
>> crypt() uses the 7 lowest characters, which makes for 7.2e16 values,
>> so I would be fine with (5), then (4)
On 9/15/17 6:52 PM, Michael Paquier wrote:
> On Sat, Sep 16, 2017 at 5:15 AM, Tom Lane wrote:
>>
>> Noting that mandrill is showing yet a different failure, one that I think
>> is inherent to chkpass:
>>
>> CREATE TABLE test (i int, p chkpass);
>> INSERT INTO test VALUES (1, 'hello'), (2, 'goo
On Sat, Sep 16, 2017 at 5:15 AM, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut writes:
>>> So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt()
>>> doesn't support the traditional two-character salt format.
>
>>> Option:
>
>>> - Use the resultmap features to make this an expec
I wrote:
> Peter Eisentraut writes:
>> So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt()
>> doesn't support the traditional two-character salt format.
>> Option:
>> - Use the resultmap features to make this an expected failure on OpenBSD.
>> - Fix the module to work on Ope
Peter Eisentraut writes:
> So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt()
> doesn't support the traditional two-character salt format.
> Option:
> - Use the resultmap features to make this an expected failure on OpenBSD.
> - Fix the module to work on OpenBSD. This woul
On 9/14/17 22:47, Peter Eisentraut wrote:
>> As for testing on more platforms, send it to the build farm?
> OK, committed, let's see.
So, we have one failure for chkpass on OpenBSD, because OpenBSD crypt()
doesn't support the traditional two-character salt format.
Option:
- Use the resultmap fea
On 9/14/17 11:01, David Steele wrote:
> On 9/8/17 1:32 PM, Peter Eisentraut wrote:
>>
>> Yes, some of the error messages had changed. Fixed patches attached.
>
> Patches apply and all tests pass. A few comments:
>
> * [PATCH v2 1/7] adminpack: Add test suite
>
> There are no regular tests for
On 9/8/17 1:32 PM, Peter Eisentraut wrote:
>
> Yes, some of the error messages had changed. Fixed patches attached.
Patches apply and all tests pass. A few comments:
* [PATCH v2 1/7] adminpack: Add test suite
There are no regular tests for pg_logdir_ls(). It looks like TAP tests
would be req
On 9/6/17 07:11, Thomas Munro wrote:
> After applying these patches cleanly on top of
> 0b554e4e63a4ba4852c01951311713e23acdae02 and running "./configure
> --enable-tap-tests --with-tcl --with-python --with-perl --with-ldap
> --with-icu && make && make check-world" I saw this failure:
Yes, some of
On Sat, Aug 12, 2017 at 1:20 PM, Peter Eisentraut
wrote:
> Here are some small test suites for some contrib modules as well as
> pg_archivecleanup that didn't have one previously, as well as one patch
> to improve code coverage in a module.
>
> Will add to commit fest. Testing on different platfo
Here are some small test suites for some contrib modules as well as
pg_archivecleanup that didn't have one previously, as well as one patch
to improve code coverage in a module.
Will add to commit fest. Testing on different platforms and with
different build configurations would be useful.
--
P
13 matches
Mail list logo