Re: [HACKERS] XLOG_NO_TRAN and XLogRecord.xl_xid

2007-02-22 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Florian G. Pflug wrote: >> * Note: xlog record is marked as outside transaction control, since we >> * want it to be redone whether the invoking transaction commits or not. > That comment is a bit misleading, I agree. We don't skip xlog entries, >

Re: [HACKERS] XLOG_NO_TRAN and XLogRecord.xl_xid

2007-02-22 Thread Heikki Linnakangas
Heikki Linnakangas wrote: Florian G. Pflug wrote: seems to imply that (some?) wal redoe records only actually get redone if the transaction that caused them eventually comitted. But given the way postgres MVCC works that doesn't make sense to me, and I also can't find any code that would actuall

Re: [HACKERS] XLOG_NO_TRAN and XLogRecord.xl_xid

2007-02-22 Thread Heikki Linnakangas
Florian G. Pflug wrote: Hi After futher reading I fear I have to bother you with another question ;-) There is a flag XLOG_NO_TRAN passed via the info parameter to XLogInsert. Now, for example the following comment in clog.c /* * Write a TRUNCATE xlog record * * We must flush the xlog record

[HACKERS] XLOG_NO_TRAN and XLogRecord.xl_xid

2007-02-22 Thread Florian G. Pflug
Hi After futher reading I fear I have to bother you with another question ;-) There is a flag XLOG_NO_TRAN passed via the info parameter to XLogInsert. Now, for example the following comment in clog.c /* * Write a TRUNCATE xlog record * * We must flush the xlog record to disk before returning