Re: [HACKERS] Window functions review

2008-11-21 Thread Hitoshi Harada
2008/11/22 Heikki Linnakangas <[EMAIL PROTECTED]>: > Just to let you know, I'm hacking this patch again, the executor part in > particular. I've got a stripped out the unfinished window frame stuff, > refactored the Window object API so that the window functions don't get to, > and don't need to, a

Re: [HACKERS] Window functions review

2008-11-21 Thread Heikki Linnakangas
Just to let you know, I'm hacking this patch again, the executor part in particular. I've got a stripped out the unfinished window frame stuff, refactored the Window object API so that the window functions don't get to, and don't need to, access tuple slots directly. And a bunch of other simpli

Re: [HACKERS] Window functions review

2008-11-12 Thread Hitoshi Harada
Thank you for your reviewing my code. 2008/11/12 Heikki Linnakangas <[EMAIL PROTECTED]>: > I've been slicing and dicing this patch for the last few days. There's a lot > of code in there, but here's some initial comments: > > The code to initialize, advance, and finalize an aggregate should be sha

[HACKERS] Window functions review

2008-11-12 Thread Heikki Linnakangas
I've been slicing and dicing this patch for the last few days. There's a lot of code in there, but here's some initial comments: The code to initialize, advance, and finalize an aggregate should be shared between Agg and Window nodes. I'm a bit disappointed that we need so much code to suppor