Re: [HACKERS] Why we don't have checksums on clog files

2016-06-13 Thread Robert Haas
On Sun, Jun 12, 2016 at 10:54 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jun 7, 2016 at 10:41 AM, Amit Kapila wrote: >>> I think it will be better if users can have an option to checksum clog >>> pages. However, I think that will need a change in page (CLOG-page) format >>> which migh

Re: [HACKERS] Why we don't have checksums on clog files

2016-06-12 Thread Tom Lane
Robert Haas writes: > On Tue, Jun 7, 2016 at 10:41 AM, Amit Kapila wrote: >> I think it will be better if users can have an option to checksum clog >> pages. However, I think that will need a change in page (CLOG-page) format >> which might not be a trivial work to accomplish. > Doesn't the pd_

Re: [HACKERS] Why we don't have checksums on clog files

2016-06-12 Thread Robert Haas
On Tue, Jun 7, 2016 at 10:41 AM, Amit Kapila wrote: > I think it will be better if users can have an option to checksum clog > pages. However, I think that will need a change in page (CLOG-page) format > which might not be a trivial work to accomplish. Doesn't the pd_checksum field exist on SLRU

Re: [HACKERS] Why we don't have checksums on clog files

2016-06-07 Thread Alexander Korotkov
On Tue, Jun 7, 2016 at 5:41 PM, Amit Kapila wrote: > On Mon, Jun 6, 2016 at 8:43 PM, Alex Ignatov > wrote: > >> Why we don't have checksums on clog files. >> >> We have checksum on pg_control, optional checksumming on data files, some >> form of checksumming on wal's. But why we don't have any c

Re: [HACKERS] Why we don't have checksums on clog files

2016-06-07 Thread Amit Kapila
On Mon, Jun 6, 2016 at 8:43 PM, Alex Ignatov wrote: > Hello! > > Why we don't have checksums on clog files. > > We have checksum on pg_control, optional checksumming on data files, some > form of checksumming on wal's. But why we don't have any checksumming on > clogs. Corruptions on clogs lead t

[HACKERS] Why we don't have checksums on clog files

2016-06-06 Thread Alex Ignatov
Hello! Why we don't have checksums on clog files. We have checksum on pg_control, optional checksumming on data files, some form of checksumming on wal's. But why we don't have any checksumming on clogs. Corruptions on clogs lead to transaction visisbility problems and database consistency vi