Re: [HACKERS] WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

2014-12-11 Thread Heikki Linnakangas
On 12/11/2014 05:57 AM, Michael Paquier wrote: On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger wrote: At line 1787 of outfuncs.c, the line: WRITE_UINT_FIELD(reltablespace) should probably say WRITE_OID_FIELD(reltablespace) since that variable is of type Oid, not uint32. Gran

Re: [HACKERS] WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

2014-12-10 Thread Michael Paquier
On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger wrote: > At line 1787 of outfuncs.c, the line: > > WRITE_UINT_FIELD(reltablespace) > > should probably say > > WRITE_OID_FIELD(reltablespace) > > since that variable is of type Oid, not uint32. > Granted, these two macros are interchang

[HACKERS] WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

2014-12-10 Thread Mark Dilger
At line 1787 of outfuncs.c, the line: WRITE_UINT_FIELD(reltablespace) should probably say WRITE_OID_FIELD(reltablespace) since that variable is of type Oid, not uint32. Granted, these two macros are interchangeable, but they won't be if we ever move to 64-bit Oids. mark -- S