On Thu, Dec 24, 2015 at 4:36 AM, Tom Lane wrote:
> As written, this would leak password strings, and it even seems possible
> that it would leave savedPassword pointing at dangling memory, since the
> free(password) inside the loop might free what savedPassword is pointing
> at, and then in princi
Michael Paquier writes:
> OK, I think that we had better address this bug for this CF. I am
> attaching an updated patch following Marko's suggestion, and marking
> this patch as ready for committer. I have noticed that the fix was
> actually not complete: ConnectDatabase needs a similar fix, this
On Fri, Nov 6, 2015 at 12:23 AM, Marko Tiikkaja wrote:
> On 11/5/15 4:11 PM, Zeus Kronion wrote:
>>
>> On Nov 1, 2015 5:04 PM, "Marko Tiikkaja" wrote:
>>>
>>> However, I don't quite like the way the password cache is kept up to date
>>
>> in the old *or* the new code. It seems to me that it shou
On 11/5/15 4:11 PM, Zeus Kronion wrote:
On Nov 1, 2015 5:04 PM, "Marko Tiikkaja" wrote:
However, I don't quite like the way the password cache is kept up to date
in the old *or* the new code. It seems to me that it should instead look
like:
if (PQconnectionUsedPassword(AH->connection))
On Nov 1, 2015 5:04 PM, "Marko Tiikkaja" wrote:
>
> On 10/25/15 10:55 PM, Zeus Kronion wrote:
>>
>> Parallel workers were failing to connect to the database when running
>> pg_dump with a connection string. The first of the following two commands
>> runs without errors, while the second one fails:
On 10/25/15 10:55 PM, Zeus Kronion wrote:
Parallel workers were failing to connect to the database when running
pg_dump with a connection string. The first of the following two commands
runs without errors, while the second one fails:
pg_dump "postgres://my-user:my-passw...@my.hostname.com:5432/m
On Fri, Oct 30, 2015 at 2:42 PM, Euler Taveira wrote:
> On 30-10-2015 10:04, Zeus Kronion wrote:
>>
>> I'm still unclear on how to write regression tests for a connectivity
>> bug. Are they necessary in this case?
>>
> There aren't regression tests for pg_dump. However, your instructions are
> suf
On 30-10-2015 10:04, Zeus Kronion wrote:
I'm still unclear on how to write regression tests for a connectivity
bug. Are they necessary in this case?
There aren't regression tests for pg_dump. However, your instructions
are sufficient to demonstrate the bug.
You could continue the thread in -b
I'm still unclear on how to write regression tests for a connectivity bug.
Are they necessary in this case?
On Sun, Oct 25, 2015 at 5:55 PM, Zeus Kronion wrote:
> Parallel workers were failing to connect to the database when running
> pg_dump with a connection string. The first of the following
Parallel workers were failing to connect to the database when running
pg_dump with a connection string. The first of the following two commands
runs without errors, while the second one fails:
pg_dump "postgres://my-user:my-passw...@my.hostname.com:5432/my-db" -Fd -f
my-dump
pg_dump "postgres://my-
10 matches
Mail list logo
