Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-07 Thread Amit Langote
On 2017/03/08 1:34, Robert Haas wrote: > On Tue, Mar 7, 2017 at 1:43 AM, Amit Langote wrote: >> On 2017/03/07 14:04, Tom Lane wrote: >>> Therefore, there should definitely be a partitioned table, hopefully with >>> a less generic name than "p1", in the final regression DB state. Whether >>> this p

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-07 Thread Robert Haas
On Tue, Mar 7, 2017 at 1:43 AM, Amit Langote wrote: > On 2017/03/07 14:04, Tom Lane wrote: >> Amit Langote writes: >>> Also, I found out that alter_table.sql mistakenly forgot to drop >>> partitioned table "p1". Patch 0002 takes care of that. >> >> While that might or might not have been intenti

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Amit Langote
On 2017/03/07 14:04, Tom Lane wrote: > Amit Langote writes: >> Also, I found out that alter_table.sql mistakenly forgot to drop >> partitioned table "p1". Patch 0002 takes care of that. > > While that might or might not have been intentional, I think it's an > astoundingly bad idea to not leave

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Tom Lane
Amit Langote writes: > Also, I found out that alter_table.sql mistakenly forgot to drop > partitioned table "p1". Patch 0002 takes care of that. While that might or might not have been intentional, I think it's an astoundingly bad idea to not leave any partitioned tables behind in the final stat

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Amit Langote
On 2017/03/07 10:49, Michael Paquier wrote: > On Tue, Mar 7, 2017 at 10:37 AM, Amit Langote > wrote: >> On 2017/03/07 7:28, Tom Lane wrote: >>> Kevin Grittner writes: With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, `make install-world`, a fresh default initdb, a star

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Michael Paquier
On Tue, Mar 7, 2017 at 10:37 AM, Amit Langote wrote: > On 2017/03/07 7:28, Tom Lane wrote: >> Kevin Grittner writes: >>> With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, >>> `make install-world`, a fresh default initdb, a start with default >>> config, `make installcheck`, conn

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Amit Langote
On 2017/03/07 7:28, Tom Lane wrote: > Kevin Grittner writes: >> With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, >> `make install-world`, a fresh default initdb, a start with default >> config, `make installcheck`, connected to the regression database >> with psql as the initial

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Tom Lane
Kevin Grittner writes: > With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, > `make install-world`, a fresh default initdb, a start with default > config, `make installcheck`, connected to the regression database > with psql as the initial superuser, and ran: > regression=# vacuu

[HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Kevin Grittner
With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, `make install-world`, a fresh default initdb, a start with default config, `make installcheck`, connected to the regression database with psql as the initial superuser, and ran: regression=# vacuum freeze analyze; WARNING: relcac

Re: [HACKERS] WARNING: relcache reference leak: relation "p1" not closed

2017-03-06 Thread Kevin Grittner
[original message held up for review -- should be along eventualy...] On Mon, Mar 6, 2017 at 3:11 PM, Kevin Grittner wrote: > With e434ad39ae7316bcf35fd578dd34ad7e1ff3c25f I did a `make world`, > `make install-world`, a fresh default initdb, a start with default > config, `make installcheck`, con