Re: [HACKERS] WAL Restore process during recovery

2012-01-25 Thread Fujii Masao
On Tue, Jan 24, 2012 at 6:43 PM, Fujii Masao wrote: >> Cleaned up the points noted, new patch attached in case you wish to >> review further. >> >> Still has bug, so still with me to fix. > > Thanks! Will review further. v3 patch contains lots of unrelated code changes like the following. - pi

Re: [HACKERS] WAL Restore process during recovery

2012-01-24 Thread Fujii Masao
On Tue, Jan 24, 2012 at 6:49 PM, Simon Riggs wrote: > On Tue, Jan 24, 2012 at 9:43 AM, Fujii Masao wrote: >> On Tue, Jan 24, 2012 at 12:23 AM, Simon Riggs wrote: >>> On Mon, Jan 23, 2012 at 12:23 PM, Fujii Masao wrote: Why does walrestore need to be invoked even when restore_command is >>>

Re: [HACKERS] WAL Restore process during recovery

2012-01-24 Thread Simon Riggs
On Tue, Jan 24, 2012 at 9:43 AM, Fujii Masao wrote: > On Tue, Jan 24, 2012 at 12:23 AM, Simon Riggs wrote: >> On Mon, Jan 23, 2012 at 12:23 PM, Fujii Masao wrote: >>> Why does walrestore need to be invoked even when restore_command is >>> not specified? It seems to be useless. We invoke walrecei

Re: [HACKERS] WAL Restore process during recovery

2012-01-24 Thread Fujii Masao
On Tue, Jan 24, 2012 at 12:23 AM, Simon Riggs wrote: > On Mon, Jan 23, 2012 at 12:23 PM, Fujii Masao wrote: >> Why does walrestore need to be invoked even when restore_command is >> not specified? It seems to be useless. We invoke walreceiver only when >> primary_conninfo is specified now. Simila

Re: [HACKERS] WAL Restore process during recovery

2012-01-23 Thread Simon Riggs
On Mon, Jan 23, 2012 at 12:23 PM, Fujii Masao wrote: > I've not reviewed the patch enough yet. Will review the patch tomorrow again. Thanks very much. I'm sure that's enough to keep me busy a few days. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7

Re: [HACKERS] WAL Restore process during recovery

2012-01-23 Thread Fujii Masao
On Fri, Jan 20, 2012 at 7:50 PM, Fujii Masao wrote: > On Fri, Jan 20, 2012 at 7:38 PM, Simon Riggs wrote: >> On Fri, Jan 20, 2012 at 3:43 AM, Fujii Masao wrote: >> >> Requested update > > Thanks! Will review. In StartChildProcess(), the code which emits an error when fork of walrestore fails is

Re: [HACKERS] WAL Restore process during recovery

2012-01-20 Thread Fujii Masao
On Fri, Jan 20, 2012 at 7:38 PM, Simon Riggs wrote: > On Fri, Jan 20, 2012 at 3:43 AM, Fujii Masao wrote: > > Requested update Thanks! Will review. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] WAL Restore process during recovery

2012-01-20 Thread Simon Riggs
On Fri, Jan 20, 2012 at 3:43 AM, Fujii Masao wrote: Requested update --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index ce659ec..469e6d

Re: [HACKERS] WAL Restore process during recovery

2012-01-19 Thread Fujii Masao
On Fri, Jan 20, 2012 at 4:17 AM, Simon Riggs wrote: > On Tue, Jan 17, 2012 at 6:52 AM, Fujii Masao wrote: >> On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs wrote: >>> WALRestore process asynchronously executes restore_command while >>> recovery continues working. >>> >>> Overlaps downloading of ne

Re: [HACKERS] WAL Restore process during recovery

2012-01-19 Thread Simon Riggs
On Tue, Jan 17, 2012 at 6:52 AM, Fujii Masao wrote: > On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs wrote: >> WALRestore process asynchronously executes restore_command while >> recovery continues working. >> >> Overlaps downloading of next WAL file to reduce time delays in file >> based archive r

Re: [HACKERS] WAL Restore process during recovery

2012-01-17 Thread Simon Riggs
On Tue, Jan 17, 2012 at 6:52 AM, Fujii Masao wrote: > On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs wrote: >> WALRestore process asynchronously executes restore_command while >> recovery continues working. >> >> Overlaps downloading of next WAL file to reduce time delays in file >> based archive r

Re: [HACKERS] WAL Restore process during recovery

2012-01-16 Thread Fujii Masao
On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs wrote: > WALRestore process asynchronously executes restore_command while > recovery continues working. > > Overlaps downloading of next WAL file to reduce time delays in file > based archive recovery. > > Handles cases of file-only and streaming/file c

[HACKERS] WAL Restore process during recovery

2012-01-15 Thread Simon Riggs
WALRestore process asynchronously executes restore_command while recovery continues working. Overlaps downloading of next WAL file to reduce time delays in file based archive recovery. Handles cases of file-only and streaming/file correctly. --  Simon Riggs   http://www.2ndQuadr