Re: [HACKERS] Void binary patch

2011-02-22 Thread Tom Lane
Robert Haas writes: > On Tue, Feb 22, 2011 at 10:15 AM, Tom Lane wrote: >> Yeah, this has been discussed before. >> >> Even though this patch is far past the CF deadline, I'm a bit tempted to >> push it into 9.1 anyway, just so we can check off that problem. > +1. Done.

Re: [HACKERS] Void binary patch

2011-02-22 Thread Merlin Moncure
On Tue, Feb 22, 2011 at 8:22 AM, rsmogura wrote: > On Tue, 22 Feb 2011 08:12:23 -0600, Merlin Moncure wrote: >> >> On Tue, Feb 22, 2011 at 6:01 AM, Robert Haas >> wrote: >>> >>> On Sun, Feb 20, 2011 at 5:20 AM, Radosław Smogura >>> wrote: Just patch for missing procedures for void send

Re: [HACKERS] Void binary patch

2011-02-22 Thread Robert Haas
On Tue, Feb 22, 2011 at 10:15 AM, Tom Lane wrote: > Merlin Moncure writes: >> On Tue, Feb 22, 2011 at 6:01 AM, Robert Haas wrote: >>> What problem does this fix? > >> void returning functions may not be called when binary protocol is >> requested currently.  this is annoying: some drivers that w

Re: [HACKERS] Void binary patch

2011-02-22 Thread Tom Lane
Merlin Moncure writes: > On Tue, Feb 22, 2011 at 6:01 AM, Robert Haas wrote: >> What problem does this fix? > void returning functions may not be called when binary protocol is > requested currently. this is annoying: some drivers that wrap libpq > or the protocol directly use the binary mode e

Re: [HACKERS] Void binary patch

2011-02-22 Thread rsmogura
On Tue, 22 Feb 2011 08:12:23 -0600, Merlin Moncure wrote: On Tue, Feb 22, 2011 at 6:01 AM, Robert Haas wrote: On Sun, Feb 20, 2011 at 5:20 AM, Radosław Smogura wrote: Just patch for missing procedures for void send/recv What problem does this fix? void returning functions may not be calle

Re: [HACKERS] Void binary patch

2011-02-22 Thread Merlin Moncure
On Tue, Feb 22, 2011 at 6:01 AM, Robert Haas wrote: > On Sun, Feb 20, 2011 at 5:20 AM, Radosław Smogura > wrote: >> Just patch for missing procedures for void send/recv > > What problem does this fix? void returning functions may not be called when binary protocol is requested currently. this i

Re: [HACKERS] Void binary patch

2011-02-22 Thread rsmogura
On Tue, 22 Feb 2011 07:01:02 -0500, Robert Haas wrote: On Sun, Feb 20, 2011 at 5:20 AM, Radosław Smogura wrote: Just patch for missing procedures for void send/recv What problem does this fix? Can not execute stored procedures in JDBC with out arguments, I think function retuning void as w

Re: [HACKERS] Void binary patch

2011-02-22 Thread Robert Haas
On Sun, Feb 20, 2011 at 5:20 AM, Radosław Smogura wrote: > Just patch for missing procedures for void send/recv What problem does this fix? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgres

Re: [HACKERS] Void binary patch

2011-02-20 Thread David Fetter
On Sun, Feb 20, 2011 at 11:20:22AM +0100, Radosław Smogura wrote: > Just patch for missing procedures for void send/recv > > Regards, > Radek Thanks! :) Style note: the project doesn't use // as a comment-to-end-of-line in C because some supported compilers don't understand it. Cheers, David. -

[HACKERS] Void binary patch

2011-02-20 Thread Radosław Smogura
Just patch for missing procedures for void send/recv Regards, Radek diff --git a/src/backend/utils/adt/pseudotypes.c b/src/backend/utils/adt/pseudotypes.c index d9329f8..614eb98 100644 --- a/src/backend/utils/adt/pseudotypes.c +++ b/src/backend/utils/adt/pseudotypes.c @@ -212,7 +212,20 @@ void_out