Re: [HACKERS] Use of copydir vs. cp

2005-07-04 Thread Bruce Momjian
Alvaro Herrera wrote: > On Mon, Jul 04, 2005 at 12:45:47PM -0400, Bruce Momjian wrote: > > Right now, we use 'cp' in unix, and a copydir() function on Win32. > > Shouldn't we be using copydir() on all platforms so we can report errors > > more easily? > > I agree. In fact, I didn't understand it

Re: [HACKERS] Use of copydir vs. cp

2005-07-04 Thread Bruce Momjian
Bruce Momjian wrote: > Right now, we use 'cp' in unix, and a copydir() function on Win32. > Shouldn't we be using copydir() on all platforms so we can report errors > more easily? Oops, I see Win32 CopyFile() in copydir.c. Seems copydir() would need some modifications to work on Unix. I added i

Re: [HACKERS] Use of copydir vs. cp

2005-07-04 Thread Alvaro Herrera
On Mon, Jul 04, 2005 at 12:45:47PM -0400, Bruce Momjian wrote: > Right now, we use 'cp' in unix, and a copydir() function on Win32. > Shouldn't we be using copydir() on all platforms so we can report errors > more easily? I agree. In fact, I didn't understand it back then when you opposed the id

[HACKERS] Use of copydir vs. cp

2005-07-04 Thread Bruce Momjian
Right now, we use 'cp' in unix, and a copydir() function on Win32. Shouldn't we be using copydir() on all platforms so we can report errors more easily? -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life