Re: [HACKERS] Use of PG_BINARY_R and "r"

2002-03-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > My assumption is that text files should use "r" and binary files use > > PG_BINARY_R. > > I believe that's correct. It seems kinda inconsistent though. > > > For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf >

Re: [HACKERS] Use of PG_BINARY_R and "r"

2002-03-22 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > My assumption is that text files should use "r" and binary files use > PG_BINARY_R. I believe that's correct. It seems kinda inconsistent though. > For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf > opened with PG_BINARY_R. The

[HACKERS] Use of PG_BINARY_R and "r"

2002-03-22 Thread Bruce Momjian
I am seeing conflicting usage of PG_BINARY_R and "r" in AllocateFile() calls. Is there a logic of when to use one or the other, or is this just badly maintained code? The significant difference is: #ifdef __CYGWIN__ #define PG_BINARY O_BINARY #define PG_BIN