Re: [HACKERS] Use of O_DIRECT only for open_* sync options

2011-03-11 Thread Bruce Momjian
Greg Smith wrote: > Bruce Momjian wrote: > > xlogdefs.h says: > > > > /* > > * Because O_DIRECT bypasses the kernel buffers, and because we never > > * read those buffers except during crash recovery, it is a win to use > > * it in all cases where we sync on each write(). We could allow O_DI

Re: [HACKERS] Use of O_DIRECT only for open_* sync options

2011-01-24 Thread Bruce Momjian
Greg Smith wrote: > Bruce Momjian wrote: > > xlogdefs.h says: > > > > /* > > * Because O_DIRECT bypasses the kernel buffers, and because we never > > * read those buffers except during crash recovery, it is a win to use > > * it in all cases where we sync on each write(). We could allow O_DI

Re: [HACKERS] Use of O_DIRECT only for open_* sync options

2011-01-23 Thread Greg Smith
Bruce Momjian wrote: xlogdefs.h says: /* * Because O_DIRECT bypasses the kernel buffers, and because we never * read those buffers except during crash recovery, it is a win to use * it in all cases where we sync on each write(). We could allow O_DIRECT * with fsync(), but because skippi

Re: [HACKERS] Use of O_DIRECT only for open_* sync options

2011-01-19 Thread Robert Haas
On Wed, Jan 19, 2011 at 1:53 PM, Bruce Momjian wrote: > Is there a reason we only use O_DIRECT with open_* sync options? > xlogdefs.h says: > > /* >  *  Because O_DIRECT bypasses the kernel buffers, and because we never >  *  read those buffers except during crash recovery, it is a win to use >  *

[HACKERS] Use of O_DIRECT only for open_* sync options

2011-01-19 Thread Bruce Momjian
Is there a reason we only use O_DIRECT with open_* sync options? xlogdefs.h says: /* * Because O_DIRECT bypasses the kernel buffers, and because we never * read those buffers except during crash recovery, it is a win to use * it in all cases where we sync on each write(). We could allow O_D