Re: Remaining items for 8.4 (was Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710))

2009-03-17 Thread Koichi Suzuki
Sorry I see the comment. I'll continue the work to fulfill the comment. 2009/3/17 Heikki Linnakangas : > Koichi Suzuki wrote: >> >> I believe all the issues pointed out in >> http://archives.postgresql.org//pgsql-hackers/2008-10/msg01387.php as >> been covered in the current patch, as discussed

Re: Remaining items for 8.4 (was Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710))

2009-03-17 Thread Heikki Linnakangas
Koichi Suzuki wrote: I believe all the issues pointed out in http://archives.postgresql.org//pgsql-hackers/2008-10/msg01387.php as been covered in the current patch, as discussed with Simon. I also understand that we're running out of time. I pointed out a few more issues here: http://archive

Re: Remaining items for 8.4 (was Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710))

2009-03-16 Thread Koichi Suzuki
Hi, I believe all the issues pointed out in http://archives.postgresql.org//pgsql-hackers/2008-10/msg01387.php as been covered in the current patch, as discussed with Simon. I also understand that we're running out of time. I'd like to push this to pgFoundry first and then work again together wi

Re: Remaining items for 8.4 (was Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710))

2009-03-16 Thread Tom Lane
Heikki Linnakangas writes: > Improve Performance of Multi-Batch Hash Join for Skewed Data Sets > I believe everyone's happy with the performance testing that's been > done. Some of the logic ought to be moved to the planner, and maybe > there's some other cleanup to do. I'll take this up next.

Remaining items for 8.4 (was Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710))

2009-03-16 Thread Heikki Linnakangas
Bruce Momjian wrote: Well, we have been trying to go simplify the SE-PostgreSQL patch since September, and while we have made progress, we still have work to do, and at this point I think we have run out of time. I think we have given it a fair shot, but I don't think it is going to make 8.4.

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-15 Thread KaiGai Kohei
Bruce Momjian wrote: Alvaro Herrera wrote: Would it make sense to instead of removing and deferring pieces bit by bit to instead work the other way around? Extract just the part of the patch that maps SELinux capabilities to Postgres privileges as a first patch? Then discuss any other parts indi

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-15 Thread Bruce Momjian
Alvaro Herrera wrote: > > Would it make sense to instead of removing and deferring pieces bit by bit > > to > > instead work the other way around? Extract just the part of the patch that > > maps SELinux capabilities to Postgres privileges as a first patch? Then > > discuss any other parts individ

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-12 Thread KaiGai Kohei
Alvaro Herrera wrote: Gregory Stark escribió: Heikki Linnakangas writes: KaiGai Kohei wrote: * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL checks db_table:{update} permission on SELECT ... FOR SHARE OF, instead of db_table:{lock} permission. This again fall

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread KaiGai Kohei
KaiGai Kohei wrote: I wonder why the vanilla PostgreSQL does not put pg_proc_aclcheck() on the ExecCallTriggerFunc(). I don't think we can assume any trigger functions are "trusted", because normal users with ACL_TRIGGER privilege can set their procedures on the allowed tables. It also means so

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread KaiGai Kohei
Robert Haas wrote: * ACL_INSERT The db_table:{insert} and db_column:{insert} for all the target columns are checked. The table-level permission does not override column-level permission, so the client need to have privileges for both of objects. It is same as other permissions. * ACL_SELECT

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Robert Haas
> * ACL_INSERT >  The db_table:{insert} and db_column:{insert} for all the target >  columns are checked. The table-level permission does not override >  column-level permission, so the client need to have privileges >  for both of objects. It is same as other permissions. > > * ACL_SELECT >  The d

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread KaiGai Kohei
Ron Mayer wrote: Alvaro Herrera wrote: Gregory Stark escribió: Heikki Linnakangas writes: KaiGai Kohei wrote: * [..feature description..] This again falls into the category of trying to have more fine-grained permissions than vanilla PostgreSQL has Would it make sense to instead of r

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Tom Lane
Alvaro Herrera writes: > Gregory Stark escribió: >> Would it make sense to instead of removing and deferring pieces bit by bit to >> instead work the other way around? Extract just the part of the patch that >> maps SELinux capabilities to Postgres privileges as a first patch? Then >> discuss any

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Ron Mayer
Alvaro Herrera wrote: > Gregory Stark escribió: >> Heikki Linnakangas writes: >> >>> KaiGai Kohei wrote: * [..feature description..] >>> This again falls into the category of trying to have more fine-grained >>> permissions than vanilla PostgreSQL has >> Would it make sense to instead of

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Alvaro Herrera
Gregory Stark escribió: > Heikki Linnakangas writes: > > > KaiGai Kohei wrote: > >> * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL > >>checks db_table:{update} permission on SELECT ... FOR SHARE OF, > >>instead of db_table:{lock} permission. > > > > This again f

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Gregory Stark
Heikki Linnakangas writes: > KaiGai Kohei wrote: >> * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL >>checks db_table:{update} permission on SELECT ... FOR SHARE OF, >>instead of db_table:{lock} permission. > > This again falls into the category of trying to have

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Heikki Linnakangas
KaiGai Kohei wrote: Heikki Linnakangas wrote: KaiGai Kohei wrote: * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL checks db_table:{update} permission on SELECT ... FOR SHARE OF, instead of db_table:{lock} permission. This again falls into the category of tryin

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread KaiGai Kohei
Heikki Linnakangas wrote: KaiGai Kohei wrote: * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL checks db_table:{update} permission on SELECT ... FOR SHARE OF, instead of db_table:{lock} permission. This again falls into the category of trying to have more fine-gr

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-11 Thread Heikki Linnakangas
KaiGai Kohei wrote: * ACL_SELECT_FOR_UPDATE has same value with ACL_UPDATE, so SE-PostgreSQL checks db_table:{update} permission on SELECT ... FOR SHARE OF, instead of db_table:{lock} permission. This again falls into the category of trying to have more fine-grained permissions than van

[HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1710)

2009-03-10 Thread KaiGai Kohei
Heikki, it is the list of updated patches: http://sepgsql.googlecode.com/files/sepgsql-core-8.4devel-r1710.patch http://sepgsql.googlecode.com/files/sepgsql-utils-8.4devel-r1710.patch http://sepgsql.googlecode.com/files/sepgsql-policy-8.4devel-r1710.patch http://sepgsql.googlecode.com/files/sepgs