Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread Robert Haas
On Fri, Aug 6, 2010 at 6:49 PM, David E. Wheeler wrote: > On Aug 6, 2010, at 3:38 PM, Tom Lane wrote: > >>> We definitely need to document the `text % text` constructor >> >> BTW, there isn't any % constructor anymore --- we agreed to provide >> only the hstore(text, text) constructor. > > Oh, I m

Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread David E. Wheeler
On Aug 6, 2010, at 3:38 PM, Tom Lane wrote: >> We definitely need to document the `text % text` constructor > > BTW, there isn't any % constructor anymore --- we agreed to provide > only the hstore(text, text) constructor. Oh, I must've been looking at an older checkout, then. Never mind. Best,

Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread Tom Lane
"David E. Wheeler" writes: > We definitely need to document the `text % text` constructor BTW, there isn't any % constructor anymore --- we agreed to provide only the hstore(text, text) constructor. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread Tom Lane
"David E. Wheeler" writes: > On Aug 6, 2010, at 3:16 PM, Tom Lane wrote: >> It looks to me like you are changing the examples of the I/O >> representation ... which did NOT change. > Hrm? The first few examples at the top? I find them confusing because there > are no single quotes around them, s

Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread David E. Wheeler
On Aug 6, 2010, at 3:16 PM, Tom Lane wrote: >> I noticed that the hstore docs still document the => operator instead >> of %. This patch changes that. > > It looks to me like you are changing the examples of the I/O > representation ... which did NOT change. Hrm? The first few examples at the to

Re: [HACKERS] Update hstore % Doc

2010-08-06 Thread Tom Lane
"David E. Wheeler" writes: > I noticed that the hstore docs still document the => operator instead > of %. This patch changes that. It looks to me like you are changing the examples of the I/O representation ... which did NOT change. regards, tom lane -- Sent via pgsql-

[HACKERS] Update hstore % Doc

2010-08-06 Thread David E. Wheeler
Hackers, I noticed that the hstore docs still document the => operator instead of %. This patch changes that. It also updates the first examples to us full SQL statements, because otherwise the use of => without surrounding single quotes was confusing. Best, David hstoredoc.patch Descripti