Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-07 Thread Bruce Momjian
On Wed, Aug 7, 2013 at 10:59:05AM -0400, Alvaro Herrera wrote: > > If we do this, perhaps we should unconditionally just print the file > > name they have to delete to undo the operation in case the server > > doesn't start; > > However, bear in mind that if the DBA is administering a server thro

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-07 Thread Alvaro Herrera
Bruce Momjian escribió: > We already have six levels of GUC settings: > > postgresql.conf > user > database > session > function > subtransaction > > If we add ALTER SYSTEM SET and config.d, we would then have eight. Actually, conf.d (not config.d) would jus

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-06 Thread Amit Kapila
On Wednesday, August 07, 2013 8:01 AM Bruce Momjian wrote: > On Tue, Aug 6, 2013 at 09:24:47PM -0400, Greg Smith wrote: > > # ALTER SYSTEM SET shared_buffers = ‘8GB’ FORCE; > > NOTICE: Changing shared_buffers only takes effect after a server > restart. > > ALTER SYSTEM > > > > Will bad examples p

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-06 Thread Amit Kapila
Tom Lane > Subject: Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER > SYSTEM SET > > On 8/5/13 2:36 PM, Josh Berkus wrote: > > Most of our users not on Heroku are running with superuser as the app > > user now. Like, 95% of them based on my personal expe

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-06 Thread Bruce Momjian
On Tue, Aug 6, 2013 at 09:24:47PM -0400, Greg Smith wrote: > # ALTER SYSTEM SET shared_buffers = ‘8GB’ FORCE; > NOTICE: Changing shared_buffers only takes effect after a server restart. > ALTER SYSTEM > > Will bad examples pop up in the Internet that just use FORCE all the > time? Sure they wil

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-06 Thread Greg Smith
On 8/5/13 2:36 PM, Josh Berkus wrote: Most of our users not on Heroku are running with superuser as the app user now. Like, 95% of them based on my personal experience (because our object permissions management sucks). My percentage wouldn't be nearly that high. 95% of database installs done

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Greg Stark
On Mon, Aug 5, 2013 at 7:02 PM, Josh Berkus wrote: > Nope. ALTER SYSTEM, from my POV, is mainly for folks who *don't* use > Puppet/Chef/whatever. Here's where I see ALTER SYSTEM being useful: > > * invididually managed servers with out centralized management (i.e. one > DBA, one server). Well a

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > On 08/05/2013 11:14 AM, Stefan Kaltenbrunner wrote: > > * in a few years from now people will just use superuser over the > > network for almost all stuff "because its easy and I can click around in > > $gui", having potential "unsafe" operations available

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Josh Berkus
On 08/05/2013 11:28 AM, Stephen Frost wrote: > * Josh Berkus (j...@agliodbs.com) wrote: >> Nope. ALTER SYSTEM, from my POV, is mainly for folks who *don't* use >> Puppet/Chef/whatever. > > Ok, that's fine, but let's try to avoid making life difficult for those > who *do* use puppet/chef/whateve

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stefan Kaltenbrunner
On 08/05/2013 08:21 PM, Josh Berkus wrote: > On 08/05/2013 11:14 AM, Stefan Kaltenbrunner wrote: >> * in a few years from now people will just use superuser over the >> network for almost all stuff "because its easy and I can click around in >> $gui", having potential "unsafe" operations available

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > Nope. ALTER SYSTEM, from my POV, is mainly for folks who *don't* use > Puppet/Chef/whatever. Ok, that's fine, but let's try to avoid making life difficult for those who *do* use puppet/chef/whatever. This capability runs a very high risk of that by al

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Josh Berkus
On 08/05/2013 11:14 AM, Stefan Kaltenbrunner wrote: > * in a few years from now people will just use superuser over the > network for almost all stuff "because its easy and I can click around in > $gui", having potential "unsafe" operations available over the network > will in turn cause a lot of a

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stefan Kaltenbrunner
On 08/05/2013 07:01 PM, Josh Berkus wrote: > Stephen, all: > > (forked from main ALTER SYSTEM discussion. this thread is meant to > discuss only this question: > > E) whether "unsafe" settings or "restart" settings should be allowed in > ALTER SYSTEM SET.) > > On 08/02/2013 01:48 PM, Stephen Fr

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stefan Kaltenbrunner
On 08/05/2013 08:02 PM, Josh Berkus wrote: > On 08/05/2013 10:49 AM, Stephen Frost wrote: >> Josh, I really have to ask- are these people who are implementing puppet >> to control these configs really clamoring to have an 'ALTER SYSTEM' PG >> command to have to code against instead of dealing with

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Josh Berkus
On 08/05/2013 10:49 AM, Stephen Frost wrote: > Josh, I really have to ask- are these people who are implementing puppet > to control these configs really clamoring to have an 'ALTER SYSTEM' PG > command to have to code against instead of dealing with text files? I > feel like you're arguing for th

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Stephen Frost
Josh, * Josh Berkus (j...@agliodbs.com) wrote: > Based on serving literally hundreds of clients, the below are the > settings we change on client servers 50% or more of the time. Other > settings I touch maybe 10% of the time. THese are also, in general, the > settings which I modify when we cre

Re: [HACKERS] Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET

2013-08-05 Thread Josh Berkus
Stephen, all: (forked from main ALTER SYSTEM discussion. this thread is meant to discuss only this question: E) whether "unsafe" settings or "restart" settings should be allowed in ALTER SYSTEM SET.) On 08/02/2013 01:48 PM, Stephen Frost wrote: > Reflecting on this a bit more, I'm curious what