Re: [HACKERS] Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

2015-07-01 Thread Michael Paquier
On Tue, Jun 30, 2015 at 9:57 PM, Andres Freund wrote: > On 2015-06-30 21:53:07 +0900, Michael Paquier wrote: >> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel >> is doing a NULL-pointer check for something that has been dereferenced >> on all the code paths leading to this

Re: [HACKERS] Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

2015-06-30 Thread Andres Freund
Hi, On 2015-06-30 21:53:07 +0900, Michael Paquier wrote: > In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel > is doing a NULL-pointer check for something that has been dereferenced > on all the code paths leading to this check. > (Yes, that's not interesting for common humans

[HACKERS] Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

2015-06-30 Thread Michael Paquier
Hi all, In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel is doing a NULL-pointer check for something that has been dereferenced on all the code paths leading to this check. (Yes, that's not interesting for common humans, Coverity sees things based on correctness). Regards, -