Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-13 Thread Peter Eisentraut
On 2/13/14, 6:25 AM, Magnus Hagander wrote: > Are you sure you made that test after my fixup patch (the one suggested > by Andres)? Because that one was at least supposed to add signal.h... works now -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-13 Thread Magnus Hagander
On Wed, Feb 12, 2014 at 10:53 PM, Peter Eisentraut wrote: > On 2/12/14, 4:34 PM, Magnus Hagander wrote: > > On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut > > wrote: > > > > On 2/12/14, 12:47 PM, Magnus Hagander wrote: > > > Since there were no other objection

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Peter Eisentraut
On 2/12/14, 4:34 PM, Magnus Hagander wrote: > On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut > wrote: > > On 2/12/14, 12:47 PM, Magnus Hagander wrote: > > Since there were no other objections, I've applied this patch. > > I'm getting a compiler warning: >

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Andres Freund
On February 12, 2014 10:34:47 PM CET, Magnus Hagander wrote: >On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut >wrote: > >> On 2/12/14, 12:47 PM, Magnus Hagander wrote: >> > Since there were no other objections, I've applied this patch. >> >> I'm getting a compiler warning: >> >> pg_basebackup

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Magnus Hagander
On Wed, Feb 12, 2014 at 10:28 PM, Peter Eisentraut wrote: > On 2/12/14, 12:47 PM, Magnus Hagander wrote: > > Since there were no other objections, I've applied this patch. > > I'm getting a compiler warning: > > pg_basebackup.c:105:3: error: implicit declaration of function 'kill' > [-Werror=impl

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Peter Eisentraut
On 2/12/14, 12:47 PM, Magnus Hagander wrote: > Since there were no other objections, I've applied this patch. I'm getting a compiler warning: pg_basebackup.c:105:3: error: implicit declaration of function 'kill' [-Werror=implicit-function-declaration] -- Sent via pgsql-hackers mailing list (

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-12 Thread Magnus Hagander
On Mon, Feb 10, 2014 at 7:39 PM, Magnus Hagander wrote: > On Mon, Feb 10, 2014 at 7:29 PM, Heikki Linnakangas < > hlinnakan...@vmware.com> wrote: > >> On 02/09/2014 02:17 PM, Magnus Hagander wrote: >> >>> If an error occurs in the foreground (backup) process of pg_basebackup, >>> and >>> we exit i

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-10 Thread Magnus Hagander
On Mon, Feb 10, 2014 at 7:29 PM, Heikki Linnakangas wrote: > On 02/09/2014 02:17 PM, Magnus Hagander wrote: > >> If an error occurs in the foreground (backup) process of pg_basebackup, >> and >> we exit in a controlled way, the background process (streaming xlog >> process) would stay around and

Re: [HACKERS] Terminating pg_basebackup background streamer

2014-02-10 Thread Heikki Linnakangas
On 02/09/2014 02:17 PM, Magnus Hagander wrote: If an error occurs in the foreground (backup) process of pg_basebackup, and we exit in a controlled way, the background process (streaming xlog process) would stay around and keep streaming. This can happen for example if disk space runs out and the

[HACKERS] Terminating pg_basebackup background streamer

2014-02-09 Thread Magnus Hagander
If an error occurs in the foreground (backup) process of pg_basebackup, and we exit in a controlled way, the background process (streaming xlog process) would stay around and keep streaming. This can happen for example if disk space runs out and there is very low activity on the server. (If there