On Fri, Jun 19, 2015 at 4:01 PM, Brendan Jurd wrote:
> On Fri, 19 Jun 2015 at 21:05 Petr Jelinek wrote:
>>
>> On 2015-06-19 09:08, Brendan Jurd wrote:
>> > I
>> > think it would be convenient and user-friendly to complete the opening
>> > bracket -- it would make it perfectly clear that an argume
On Fri, 19 Jun 2015 at 21:05 Petr Jelinek wrote:
> On 2015-06-19 09:08, Brendan Jurd wrote:
> > I
> > think it would be convenient and user-friendly to complete the opening
> > bracket -- it would make it perfectly clear that an argument is required
> > for the syntax to be valid.
> >
>
> Agreed,
On 2015-06-19 09:08, Brendan Jurd wrote:
On Sun, 14 Jun 2015 at 20:44 Petr Jelinek mailto:p...@2ndquadrant.com>> wrote:
looks like I omitted psql tab completion from the TABLESAMPLE patch. The
attached patch adds it.
Hi Petr,
I'm doing an initial review of this patch.
Thanks
With
On Sun, 14 Jun 2015 at 20:44 Petr Jelinek wrote:
> looks like I omitted psql tab completion from the TABLESAMPLE patch. The
> attached patch adds it.
>
Hi Petr,
I'm doing an initial review of this patch.
It applies and compiles cleanly. Code style is consistent with its
surroundings.
With th
Hi,
looks like I omitted psql tab completion from the TABLESAMPLE patch. The
attached patch adds it.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
i
