Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-12-20 Thread Michael Paquier
On Mon, Dec 21, 2015 at 3:34 PM, Jeff Janes wrote: > On Tue, Dec 1, 2015 at 10:37 PM, Michael Paquier > wrote: >> >> With the refactoring of tab-complete.c that is moving on, perhaps this >> entry should be moved to next CF. Thoughts? > > The now-committed tab-complete.c refactoring renders this

Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-12-20 Thread Jeff Janes
On Tue, Dec 1, 2015 at 10:37 PM, Michael Paquier wrote: > > With the refactoring of tab-complete.c that is moving on, perhaps this > entry should be moved to next CF. Thoughts? The now-committed tab-complete.c refactoring renders this unnecessary, so I've marked this patch as rejected. Thanks,

Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-12-01 Thread Michael Paquier
On Wed, Nov 18, 2015 at 2:12 AM, Jeff Janes wrote: > On Mon, Sep 28, 2015 at 8:48 AM, Robert Haas wrote: >> On Sat, Sep 26, 2015 at 7:24 AM, Michael Paquier >> wrote: >>> On Sat, Sep 26, 2015 at 7:18 AM, Jeff Janes wrote: If I have "alter table foo alter COLUMN bar SET STATISTICS" in the l

Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-11-17 Thread Jeff Janes
On Mon, Sep 28, 2015 at 8:48 AM, Robert Haas wrote: > On Sat, Sep 26, 2015 at 7:24 AM, Michael Paquier > wrote: >> On Sat, Sep 26, 2015 at 7:18 AM, Jeff Janes wrote: >>> If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line >>> buffer, >>> it tab completes to add " TO", which i

Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-09-28 Thread Robert Haas
On Sat, Sep 26, 2015 at 7:24 AM, Michael Paquier wrote: > On Sat, Sep 26, 2015 at 7:18 AM, Jeff Janes wrote: >> If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line >> buffer, >> it tab completes to add " TO", which is not legal. >> >> The attached patch makes it not tab comple

Re: [HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-09-26 Thread Michael Paquier
On Sat, Sep 26, 2015 at 7:18 AM, Jeff Janes wrote: > If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line > buffer, > it tab completes to add " TO", which is not legal. > > The attached patch makes it not tab complete anything at all, which is at > least not actively misleading.

[HACKERS] Tab completion for ALTER COLUMN SET STATISTICS

2015-09-25 Thread Jeff Janes
If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line buffer, it tab completes to add " TO", which is not legal. The attached patch makes it not tab complete anything at all, which is at least not actively misleading. I thought of having it complete "-1", "" so that it gives a c