Re: [HACKERS] Suggested change in include/utils/elog.h

2000-10-10 Thread Michael Meskes
On Sun, Oct 08, 2000 at 01:37:45PM -0400, Bruce Momjian wrote: > > But perhaps it is ecpg's fault for including "elog.h". > > IMHO these defines should never leave the database kernel. > ... > Yes, leaking into user programs is a bad practice. Is there a > solution/patch for that? Hmm, I haven'

Re: [HACKERS] Suggested change in include/utils/elog.h

2000-10-09 Thread Christof Petig
Bruce Momjian wrote: > > > > > PostgreSQL would probably "play" better with other products if > > > > > the DEBUG macro had a prefix, maybe PGSQLDEBUG or similar. > > > > > > > > > > Until there is some fix in this area, plperl will not build with > > > > > a version of perl that has debugging en

Re: [HACKERS] Suggested change in include/utils/elog.h

2000-10-08 Thread Bruce Momjian
> > > > PostgreSQL would probably "play" better with other products if > > > > the DEBUG macro had a prefix, maybe PGSQLDEBUG or similar. > > > > > > > > Until there is some fix in this area, plperl will not build with > > > > a version of perl that has debugging enabled. > > > > > > It even got

Re: [HACKERS] Suggested change in include/utils/elog.h

2000-10-02 Thread Christof Petig
Magnus Hagander wrote: > If you do decide to prefix DEBUG, please consider prefixing at least ERROR > as well. It produces a lot of warnings when compiling on Win32 (ERROR is > already defined as part of the standard windows headers). It's just > warnings, though. > > //Magnus > > > Do other peop

RE: [HACKERS] Suggested change in include/utils/elog.h

2000-09-30 Thread Magnus Hagander
If you do decide to prefix DEBUG, please consider prefixing at least ERROR as well. It produces a lot of warnings when compiling on Win32 (ERROR is already defined as part of the standard windows headers). It's just warnings, though. //Magnus > Do other people have a comment on this. I am incl

Re: [HACKERS] Suggested change in include/utils/elog.h

2000-09-29 Thread Bruce Momjian
Do other people have a comment on this. I am inclined to leave it along. This is the first complaint I have heard, and elog(PGDEBUG) just looks funny. We don't prefix NOTICE or ERROR. > In the file > >include/utils/elog.h > > there is a macro named > >DEBUG > > that conflicts with