Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread NikhilS
Apologies! As Alvaro guessed it correctly I was working with 8.2 sources. Sorry for the noise. Regards, Nikhils On 8/29/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > NikhilS <[EMAIL PROTECTED]> writes: > > The attached patch should fix this. > > And break other things, no doubt. needed = 0 is a pe

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Tom Lane
NikhilS <[EMAIL PROTECTED]> writes: > The attached patch should fix this. And break other things, no doubt. needed = 0 is a perfectly valid edge case and mustn't be rejected here. (In fact, I doubt you'd even get through the regression tests with this patch ... how much did you test it?) The re

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Alvaro Herrera
Andrew Dunstan escribió: > > > NikhilS wrote: >> >> >> I also found the absence of a function like resetStringInfo() a bit >> puzzling. A found a lot of places where the code was resetting the "len" >> field to 0 and assigning '\0' to the data field to reset the variable. >> This seems to be the

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Andrew Dunstan
NikhilS wrote: I also found the absence of a function like resetStringInfo() a bit puzzling. A found a lot of places where the code was resetting the "len" field to 0 and assigning '\0' to the data field to reset the variable. This seems to be the only missing API which will be needed whi

[HACKERS] StringInfo misc. issues

2007-08-29 Thread NikhilS
Hi, I palloc0'ed a variable of type StringInfo and without doing an initStringInfo() (forgot to do it i.e.) tried to append some stuff to it using appendStringInfo(). It went into a tight loop within the function enlargeStringInfo() at: while (needed > newlen) Must be a common enough case for a