Re: [HACKERS] Strange heuristic in analyze.c

2010-02-08 Thread Greg Stark
On Fri, Feb 5, 2010 at 8:53 PM, Bruce Momjian wrote: > Do you want a C comment to document this problem? Well I would rather a better heuristic :) We really need some statistics nerds in this group who can pipe up when these kinds of issues come up. There must be a good way to estimate the proba

Re: [HACKERS] Strange heuristic in analyze.c

2010-02-05 Thread Bruce Momjian
Greg Stark wrote: > So I never realized the consequences of this little heuristic in > analyze.c in the handling of very low cardinality columns where we > want to just capture the complete list of values in the mcv and throw > away the histogram: > > else if (toowide_cnt == 0 && nmu

[HACKERS] Strange heuristic in analyze.c

2010-01-29 Thread Greg Stark
So I never realized the consequences of this little heuristic in analyze.c in the handling of very low cardinality columns where we want to just capture the complete list of values in the mcv and throw away the histogram: else if (toowide_cnt == 0 && nmultiple == ndistinct)