Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Joe Conway
Joe Conway wrote: ...the "BEGIN" statement returned successfully as usual, but for some reason left (PQtransactionStatus(conn) != PQTRANS_IDLE), causing dblink_open() to start a transaction and later complete it on line 454. Oops, I meant "... some reason left (PQtransactionStatus(conn) ==

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Joe Conway
Tom Lane wrote: What's even more interesting is that there are now three later runs of HEAD on osprey, and none of them failed. So unless Remi's been fooling with the environment on that machine, this was a one-shot irreproducible failure. That's disturbing in a different way ... http://www.pg

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Tom Lane
Tom Lane <[EMAIL PROTECTED]> writes: > Joe Conway <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> It looks to me like the diffs are consistent with the idea that the >>> test is using a copy of dblink that predates this patch ... >> I would think that the diffs would be significantly larger if

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >>> It looks to me like the diffs are consistent with the idea that the >>> test is using a copy of dblink that predates this patch ... > I would think that the diffs would be significantly larger if that were > the case. In fact, when was

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: I haven't really looked at the buildfarm before -- I might be blind, but I couldn't figure out how to see the regression.diff file. It's on the cited page, if you scroll down far enough. OK, I'm officially blind (so much for that lasik

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Andrew Dunstan
Tom Lane wrote: Note to Andrew: would it make sense for the larger log files to be split out as linked pages in a buildfarm report? regards, tom lane I will put it on the TODO list. cheers andrew ---(end of broadcast)--

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> BTW, I was led to notice this while examining the current buildfarm >> failure report from osprey, >> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=osprey&dt=2006-06-17%2004:00:16 > I haven't really looked at the buildfarm before -- I

Re: [HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-20 Thread Joe Conway
Tom Lane wrote: Lines 509-512 of contrib/dblink/expected/dblink.out read: -- this should fail because there is no open transaction SELECT dblink_exec('myconn','DECLARE xact_test CURSOR FOR SELECT * FROM foo'); ERROR: sql error DETAIL: ERROR: cursor "xact_test" already exists The error messag

[HACKERS] Slightly bogus regression test for contrib/dblink

2006-06-18 Thread Tom Lane
Lines 509-512 of contrib/dblink/expected/dblink.out read: -- this should fail because there is no open transaction SELECT dblink_exec('myconn','DECLARE xact_test CURSOR FOR SELECT * FROM foo'); ERROR: sql error DETAIL: ERROR: cursor "xact_test" already exists The error message is not consisten