Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Noah Misch
On Sun, Nov 02, 2014 at 10:53:27PM +0100, Marko Tiikkaja wrote: > On 11/2/14, 10:34 PM, Noah Misch wrote: > >On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: > >>*** a/contrib/pgcrypto/pgp-decrypt.c > >>--- b/contrib/pgcrypto/pgp-decrypt.c > >>*** > >>*** 1069,1075 p

Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Marko Tiikkaja
On 11/2/14, 10:34 PM, Noah Misch wrote: On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: *** a/contrib/pgcrypto/pgp-decrypt.c --- b/contrib/pgcrypto/pgp-decrypt.c *** *** 1069,1075 pgp_skip_packet(PullFilter *pkt) while (res > 0) res = pul

Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Tomas Vondra
On 2.11.2014 22:34, Noah Misch wrote: > On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: >> *** a/contrib/pgcrypto/pgp-decrypt.c >> --- b/contrib/pgcrypto/pgp-decrypt.c >> *** >> *** 1069,1075 pgp_skip_packet(PullFilter *pkt) >> >> while (res > 0) >>

Re: [HACKERS] Silly coding in pgcrypto

2014-11-02 Thread Noah Misch
On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote: > *** a/contrib/pgcrypto/pgp-decrypt.c > --- b/contrib/pgcrypto/pgp-decrypt.c > *** > *** 1069,1075 pgp_skip_packet(PullFilter *pkt) > > while (res > 0) > res = pullf_read(pkt, 32 * 1024, &tmp);

[HACKERS] Silly coding in pgcrypto

2014-11-01 Thread Marko Tiikkaja
Hi, Patch attached to fix some sillyness in pgp_expect_packet_end() and pgp_skip_packet(). Will add to the next commitfest unless someone picks this one up before that. .marko *** a/contrib/pgcrypto/pgp-decrypt.c --- b/contrib/pgcrypto/pgp-decrypt.c *** *** 1069,1075 pgp_sk