Re: [HACKERS] Separate psql commands from arguments

2008-04-12 Thread Bernd Helmle
--On Freitag, April 11, 2008 13:53:11 -0500 Decibel! <[EMAIL PROTECTED]> wrote: As Bernd said, I see this as simple search and replace, and then stick it in the command buffer. If you define an alias that calls itself, you could end up with a stack overflow, same as with server functions. The

Re: [HACKERS] Separate psql commands from arguments

2008-04-11 Thread Decibel!
On Apr 10, 2008, at 4:48 PM, Gregory Stark wrote: Well I feel like storing a query and resending it later is something predictable which will work reliably. Storing a psql input line and reinterpreting it later is surely going to cause weird things to happen. Just for some examples off the to

Re: [HACKERS] Separate psql commands from arguments

2008-04-11 Thread Gregory Stark
"Bernd Helmle" <[EMAIL PROTECTED]> writes: >> What happens to aliases when you change the encoding in the middle of >> running one? Actually, come to think of it, what *does* happen to aliases >> when the encoding changes?? > > Hmm? What happens if you are going to change your encoding within mul

Re: [HACKERS] Separate psql commands from arguments

2008-04-11 Thread Bernd Helmle
--On Donnerstag, April 10, 2008 22:48:24 +0100 Gregory Stark <[EMAIL PROTECTED]> wrote: Well I feel like storing a query and resending it later is something predictable which will work reliably. Storing a psql input line and reinterpreting it later is surely going to cause weird things to happe

Re: [HACKERS] Separate psql commands from arguments

2008-04-10 Thread Gregory Stark
"Decibel!" <[EMAIL PROTECTED]> writes: > Am Samstag, 5. April 2008 schrieb Gregory Stark: >> On Apr 10, 2008, at 7:50 AM, Peter Eisentraut wrote: >>> I also don't see any point in allowing aliases which call other psql >>> commands. > > Why disallow it? I think it could be very useful. Well I fe

Re: [HACKERS] Separate psql commands from arguments

2008-04-10 Thread Decibel!
Am Samstag, 5. April 2008 schrieb Gregory Stark: On Apr 10, 2008, at 7:50 AM, Peter Eisentraut wrote: I also don't see any point in allowing aliases which call other psql commands. Why disallow it? I think it could be very useful. One thing I sometimes find myself doing is wanting to run a

Re: [HACKERS] Separate psql commands from arguments

2008-04-10 Thread Alvaro Herrera
Gregory Stark escribió: > Ah but I would use it. In particular the query I found myself writing *all* > the time over and over again in Oracle was: > > select count(*),n from (select count(*) as n from group by ) group > by n > > I can type it out now from finger-memory without even thinking a

Re: [HACKERS] Separate psql commands from arguments

2008-04-10 Thread Gregory Stark
"Peter Eisentraut" <[EMAIL PROTECTED]> writes: > But other people do want to use it. If it is too confusing for you, don't > use > it. That's what's nice about this feature: If you don't use it, it doesn't > affect you at all. Ah but I would use it. In particular the query I found myself wr

Re: [HACKERS] Separate psql commands from arguments

2008-04-10 Thread Peter Eisentraut
Am Samstag, 5. April 2008 schrieb Gregory Stark: > Regardless of whether we go ahead with this (and I'm not fond of it > primarily because I want \c& to "work"), I think we would still be better > off keeping the aliases in a separate namespace from psql commands and > having an explicit command fo

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Apr 5, 2008 at 12:14 PM, Gregory Stark wrote: > "Brendan Jurd" writes: > > Okay, but what on earth is "\c&" and what would you expect it to do > > when it "works"? I suppose you're connecting to a database, but > > somehow I don't think y

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Gregory Stark
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > On Sat, Apr 5, 2008 at 10:00 AM, Gregory Stark wrote: >> Regardless of whether we go ahead with this (and I'm not fond of it >> primarily >> because I want \c& to "work"), > > Okay, but what on earth is "\c&" and what would you expect it to do > whe

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Apr 5, 2008 at 10:00 AM, Gregory Stark wrote: > Regardless of whether we go ahead with this (and I'm not fond of it primarily > because I want \c& to "work"), Okay, but what on earth is "\c&" and what would you expect it to do when it "work

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Brendan Jurd" <[EMAIL PROTECTED]> writes: >> +1 for dropping this quirk. And, if there are no objections (or other >> takers), I volunteer to write a patch. > Regardless of whether we go ahead with this (and I'm not fond of it primarily > because I wan

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Alvaro Herrera
Gregory Stark escribió: > I still see it much cleaner and much clearer for people reading the script to > have something like > > \query dpkg perl-base* This also helps to separate the namespaces for tab completion if you want to use this in interactive mode. -- Alvaro Herrera

Re: [HACKERS] Separate psql commands from arguments

2008-04-04 Thread Gregory Stark
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > +1 for dropping this quirk. And, if there are no objections (or other > takers), I volunteer to write a patch. Regardless of whether we go ahead with this (and I'm not fond of it primarily because I want \c& to "work"), I think we would still be bet

Re: [HACKERS] Separate psql commands from arguments (was: psql command aliases support)

2008-04-03 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, Apr 4, 2008 at 6:35 AM, Bernd Helmle wrote: > Here's a quick and dirty patch which removes the responsible code from psql > (maybe not enough, but short testing shows it's working). Sorry for the > unified diff > I didn't realise it woul

[HACKERS] Separate psql commands from arguments (was: psql command aliases support)

2008-04-03 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Moving to -hackers ... -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: http://getfiregpg.org iD8DBQFH9RwN5YBsbHkuyV0RAr9ZAKD+XwNYYw3ugsTvowvKImOlKMZzPQCfTHkQ u9jLkEIAWI/0MbNzzxBt0ok= =So1n -END PGP SIGNATURE- On Fri,